Skip to content

Add known limitations for gios integration#42792

Closed
mik-laj wants to merge 3 commits into
home-assistant:nextfrom
mik-laj:patch-23
Closed

Add known limitations for gios integration#42792
mik-laj wants to merge 3 commits into
home-assistant:nextfrom
mik-laj:patch-23

Conversation

@mik-laj
Copy link
Copy Markdown
Contributor

@mik-laj mik-laj commented Dec 29, 2025

Proposed change

Related to discussion: home-assistant/core#155603 (comment)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Added known limitations section regarding sensor availability and data polling frequency.
Copilot AI review requested due to automatic review settings December 29, 2025 17:29
@mik-laj mik-laj requested a review from bieniu as a code owner December 29, 2025 17:29
@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Dec 29, 2025
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant Bot added the next This PR goes into the next branch label Dec 29, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 29, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 3faffd4
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/6952bb1bdae7f10008a1c411
😎 Deploy Preview https://deploy-preview-42792--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mik-laj
Copy link
Copy Markdown
Contributor Author

mik-laj commented Dec 29, 2025

This PR makes changes in documentation that exists only in next branch, so the branch is correct.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes documentation for the GIOS integration by removing a note about sensor availability and data refresh rates from the "Available sensors" section, and adding a new "Known limitations" section that clarifies these constraints more explicitly.

  • Moves sensor availability information from an informal note to a dedicated "Known limitations" section
  • Adds context about data polling frequency and potential data staleness
  • Improves document structure by grouping limitations in a standard section

Comment thread source/_integrations/gios.markdown Outdated
@home-assistant home-assistant Bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Dec 29, 2025
@home-assistant home-assistant Bot added the has-parent This PR has a parent PR in another repo label Dec 29, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bieniu
Copy link
Copy Markdown
Member

bieniu commented Dec 29, 2025

PR is targeting the wrong branch

obraz

@bieniu bieniu marked this pull request as draft December 29, 2025 21:22
@bieniu
Copy link
Copy Markdown
Member

bieniu commented Dec 29, 2025

This PR makes changes in documentation that exists only in next branch, so the branch is correct.

It seems to me that #42740 should be targeted to the current branch.

@mik-laj
Copy link
Copy Markdown
Contributor Author

mik-laj commented Dec 29, 2025

@bieniu Yes. That's right. I chose the wrong branch because I was missing the changes in this mik-laj@67ef18e when I was reviewing whether everything was covered in the final documentation for this integration. This doesn't seem to be a big issues, as it looks like the next and current branches will be synchronized in a maximum of 3 days, as with the new month we have a new release.

Since the previous change was merged into next branch, I cannot merge this change into another branch.

@bieniu
Copy link
Copy Markdown
Member

bieniu commented Dec 30, 2025

Currently, the next branch is equivalent to HA 2026.2, so targeting these types of changes to it doesn't make sense. In my opinion, we should wait until the 2026.1 release and open a new PR for the current branch.

@mik-laj mik-laj changed the base branch from next to current December 30, 2025 11:52
@home-assistant home-assistant Bot removed the next This PR goes into the next branch label Dec 30, 2025
@home-assistant home-assistant Bot added current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Dec 30, 2025
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@mik-laj mik-laj changed the base branch from current to next February 3, 2026 23:34
@home-assistant home-assistant Bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Feb 3, 2026
@home-assistant home-assistant Bot added the next This PR goes into the next branch label Feb 3, 2026
@mik-laj mik-laj closed this Feb 3, 2026
@home-assistant home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Feb 3, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants