Skip to content

Bluesound deprecate actions bluesound.join and bluesound.unjoin#42651

Merged
silamon merged 2 commits into
home-assistant:nextfrom
LouisChrist:bluesound_deprecate_custom_options
Dec 26, 2025
Merged

Bluesound deprecate actions bluesound.join and bluesound.unjoin#42651
silamon merged 2 commits into
home-assistant:nextfrom
LouisChrist:bluesound_deprecate_custom_options

Conversation

@LouisChrist
Copy link
Copy Markdown
Contributor

@LouisChrist LouisChrist commented Dec 19, 2025

Proposed change

This adds a note that the custom actions bluesound.join and bluesound.unjoin are deprecated. And points to media_player.join and media_player.unjoin as an alternative.

This removes all deprecated actions from the docs. Including two that were deprecated a while ago.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copilot AI review requested due to automatic review settings December 19, 2025 16:38
@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Dec 19, 2025
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 19, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 59250fe
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/694bbda01c62340008d9693b
😎 Deploy Preview https://deploy-preview-42651--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds deprecation notices to the Bluesound integration documentation for two custom actions: bluesound.join and bluesound.unjoin, directing users to use the standard media player actions media_player.join and media_player.unjoin instead.

Key changes

  • Added deprecation notice for bluesound.join action
  • Added deprecation notice for bluesound.unjoin action

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Dec 19, 2025
@home-assistant home-assistant Bot added the parent-merged The parent PR has been merged already label Dec 23, 2025
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally just omit them from the docs altogether

@home-assistant home-assistant Bot marked this pull request as draft December 23, 2025 20:48
@home-assistant
Copy link
Copy Markdown

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@LouisChrist
Copy link
Copy Markdown
Contributor Author

We generally just omit them from the docs altogether

I removed them. And also the other two deprecated actions.

@LouisChrist LouisChrist marked this pull request as ready for review December 24, 2025 10:18
@home-assistant home-assistant Bot requested a review from joostlek December 24, 2025 10:18
@silamon silamon dismissed joostlek’s stale review December 26, 2025 10:28

comments addressed

@silamon silamon merged commit 46e365c into home-assistant:next Dec 26, 2025
7 checks passed
@home-assistant home-assistant Bot removed parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on labels Dec 26, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 27, 2025
@LouisChrist LouisChrist deleted the bluesound_deprecate_custom_options branch December 27, 2025 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants