Skip to content

Add advanced section for generic camera config flow#42615

Merged
MartinHjelmare merged 1 commit into
nextfrom
edenhaus-generic-camera-advanced
Dec 18, 2025
Merged

Add advanced section for generic camera config flow#42615
MartinHjelmare merged 1 commit into
nextfrom
edenhaus-generic-camera-advanced

Conversation

@edenhaus
Copy link
Copy Markdown
Member

Proposed change

Add advanced section for generic camera config flow

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copilot AI review requested due to automatic review settings December 17, 2025 07:49
@edenhaus edenhaus requested a review from davet2001 as a code owner December 17, 2025 07:49
@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Dec 17, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 17, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 3c47bdc
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/69426082ab2c0300089de4ad
😎 Deploy Preview https://deploy-preview-42615--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the generic camera integration documentation by introducing a structured "Advanced settings" section in the configuration flow. The change improves user experience by grouping specialized configuration options under a collapsible advanced section, making the initial setup cleaner and less overwhelming for basic users while keeping advanced options accessible.

Key changes:

  • Restructured configuration documentation to nest advanced options under an "Advanced settings" parent key
  • Added a descriptive warning message for the advanced settings section
  • Maintained all existing configuration options with their original descriptions

Frame Rate:
description: The number of frames-per-second (FPS) of the stream. Can cause heavy traffic on the network and/or heavy load on the camera.
Verify SSL certificate:
description: Enable or disable SSL certificate verification. Set to false to use an http-only camera, or you have a self-signed SSL certificate and haven't installed the CA certificate to enable verification.
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "false" should be formatted as code since it's a boolean value. Consider changing "Set to false" to "Set to false" to properly format this technical value.

Copilot uses AI. Check for mistakes.
Limit refetch to URL change:
description: Limits re-fetching of the remote image to when the URL changes. Only relevant if using a template to fetch the remote image.
Use wallclock as timestamps:
description: ([Advanced Mode](/blog/2019/07/17/release-96/#advanced-mode) only) Rewrite the camera timestamps. This may help with playback or crashing issues from Wi-Fi cameras or cameras of certain brands (e.g., EZVIZ).
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to "Advanced Mode" in parentheses appears redundant now that this setting is already within the "Advanced settings" section. Consider simplifying the description to avoid confusion and improve readability.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @edenhaus 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Dec 17, 2025
@home-assistant home-assistant Bot added the parent-merged The parent PR has been merged already label Dec 18, 2025
@MartinHjelmare MartinHjelmare merged commit f927550 into next Dec 18, 2025
15 checks passed
@home-assistant home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Dec 18, 2025
@MartinHjelmare MartinHjelmare deleted the edenhaus-generic-camera-advanced branch December 18, 2025 12:31
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants