Skip to content

Added TekSavvy data usage sensor documentation.#4227

Merged
fabaff merged 6 commits into
home-assistant:nextfrom
jpjodoin:teksavvy
Jan 18, 2018
Merged

Added TekSavvy data usage sensor documentation.#4227
fabaff merged 6 commits into
home-assistant:nextfrom
jpjodoin:teksavvy

Conversation

@jpjodoin
Copy link
Copy Markdown
Contributor

@jpjodoin jpjodoin commented Dec 17, 2017

Description:

Pull request in home-assistant (if applicable): home-assistant/core#11186

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Dec 18, 2017
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpjodoin I've left you some feedback on this PR, could you please take a look? Awesome 👓

- onpeak_remaining
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpjodoin Please replace this part with the configuration tags.
For more information about using those, please see: https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I will change that. Quick question, right now I'm using the configuration "monitored_variables", do you think it would be preferable if I would change for "monitored_conditions" ? Is this a standard configuration name ?

Thanks !

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, that question would be more appropriate in the parent PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, actually both are part of the standard const, I will keep monitored_variables as it seems more appropriate. Thanks.

---
layout: page
title: "TekSavvy"
description: "Instructions how to integrate TekSavvy data usage within Home Assistant."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar:

  • Instructions how to integrate - Instructions on how to integrate

@jpjodoin
Copy link
Copy Markdown
Contributor Author

I made the requested changes.

Thanks !

frenck
frenck previously approved these changes Dec 19, 2017
@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 19, 2017

Thanks @jpjodoin
Can be merged as soon as the parent PR gets merged.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@fabaff fabaff merged commit 4d19f4b into home-assistant:next Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants