Skip to content

Add documentation for iGlo component#4222

Merged
fabaff merged 3 commits into
home-assistant:nextfrom
jesserockz:iglo-lights
Jan 6, 2018
Merged

Add documentation for iGlo component#4222
fabaff merged 3 commits into
home-assistant:nextfrom
jesserockz:iglo-lights

Conversation

@jesserockz
Copy link
Copy Markdown
Member

@jesserockz jesserockz commented Dec 16, 2017

Description:
Adding documentation for new iGlo component

Pull request in home-assistant (if applicable): home-assistant/core#11171

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Dec 18, 2017
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesserockz Reviewed the docs, got 2 tiny notes. Could you please take a look? 👍

Comment thread source/_components/light.iglo.markdown Outdated
logo: iglo.png
ha_category: Light
ha_iot_class: "Local Polling"
ha_release: 0.60
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly would not make it into the 0.60 release, since it it already out there.
You might want to consider changing it to 0.61.

Comment thread source/_components/light.iglo.markdown Outdated
---
layout: page
title: "iGlo"
description: "Instructions how to integrate LIFX into Home Assistant."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny spelling issue: Instructions on how to integrate

frenck
frenck previously approved these changes Dec 18, 2017
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for updating @jesserockz.
Can be merged as soon as the parent PR gets merged.

@jesserockz
Copy link
Copy Markdown
Member Author

Cheers @frenck

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 4116766 into home-assistant:next Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants