Skip to content

Correct fail2ban integration docs#41965

Merged
frenck merged 2 commits into
currentfrom
edenhaus-fail2ban
Nov 25, 2025
Merged

Correct fail2ban integration docs#41965
frenck merged 2 commits into
currentfrom
edenhaus-fail2ban

Conversation

@edenhaus
Copy link
Copy Markdown
Member

@edenhaus edenhaus commented Nov 25, 2025

Proposed change

Correct fail2ban integration docs

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@edenhaus edenhaus added this to the 2025.12 milestone Nov 25, 2025
Copilot AI review requested due to automatic review settings November 25, 2025 11:01
@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Nov 25, 2025
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Nov 25, 2025

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copilot AI reviewed Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the fail2ban integration documentation to clarify installation requirements and log file access. However, there's a mismatch between the PR title ("Add docs for Backblaze B2 integration") and the actual changes (corrections to fail2ban documentation).

Key Changes

  • Restricts integration availability to only Home Assistant Container installations (previously supported Core, and excluded OS/Supervised/Container)
  • Updates the log file access requirement to specify that the fail2ban log must be mounted to the Container

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread source/_integrations/fail2ban.markdown Outdated
Comment thread source/_integrations/fail2ban.markdown
{% important %}

Your system must have `fail2ban` installed and correctly configured for this sensor to work. In addition, Home Assistant must be able to read the `fail2ban` log file.
Your system must have `fail2ban` installed and correctly configured for this sensor to work. In addition, the `fail2ban` log file must be mounted to the Home Assistant container to be able to read it.
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this update is more specific for Container installations, it creates inconsistency with line 21's claim that the integration is only available on Container. If the integration also supports Core (as it originally did), this sentence should accommodate both scenarios. Consider: "In addition, Home Assistant must be able to read the fail2ban log file (for Container installations, the log file must be mounted to the container)."

Suggested change
Your system must have `fail2ban` installed and correctly configured for this sensor to work. In addition, the `fail2ban` log file must be mounted to the Home Assistant container to be able to read it.
Your system must have `fail2ban` installed and correctly configured for this sensor to work. In addition, Home Assistant must be able to read the `fail2ban` log file (for Container installations, the log file must be mounted to the container).

Copilot uses AI. Check for mistakes.
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 25, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 5f3e9cc
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/6925b78091da4d00088a856a
😎 Deploy Preview https://deploy-preview-41965--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@edenhaus edenhaus changed the title Add docs for Backblaze B2 integration (#39169) Correct fail2ban integration docs Nov 25, 2025
@frenck frenck changed the base branch from next to current November 25, 2025 11:13
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 25, 2025

My bad! Sorry for the pings everyone 🙏

@edenhaus Can you target this PR against the current branch please?

../Frenck

@frenck frenck removed this from the 2025.12 milestone Nov 25, 2025
@edenhaus
Copy link
Copy Markdown
Member Author

edenhaus commented Nov 25, 2025

But on the "current" (stand HA 2025.11) we still theoretically support core :)

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 25, 2025

@edenhaus In terms of documentation, we always remove deprecated features as soon as they are deprecated.

@edenhaus edenhaus requested a review from a team as a code owner November 25, 2025 14:04
@edenhaus edenhaus changed the base branch from next to current November 25, 2025 14:04
@home-assistant home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Nov 25, 2025
@home-assistant home-assistant Bot added the current This PR goes into the current branch label Nov 25, 2025
@edenhaus edenhaus requested review from frenck and removed request for a team November 25, 2025 14:05
frenck
frenck approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @edenhaus 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@frenck frenck frenck approved these changes

Assignees

@frenck frenck

Labels

current This PR goes into the current branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edenhaus @frenck