Skip to content

Use template for query in SQL#40345

Merged
c0ffeeca7 merged 4 commits into
nextfrom
gj-20250808-01
Nov 7, 2025
Merged

Use template for query in SQL#40345
c0ffeeca7 merged 4 commits into
nextfrom
gj-20250808-01

Conversation

@gjohansson-ST
Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST commented Aug 8, 2025

Proposed change

Change query from being a string to a template in SQL integration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copilot AI review requested due to automatic review settings August 8, 2025 22:12
@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Aug 8, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 8, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 0151ccd
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/690d729dbd9185000816d76f
😎 Deploy Preview https://deploy-preview-40345--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gjohansson-ST gjohansson-ST mentioned this pull request Aug 8, 2025
Merged
19 tasks
Copilot AI reviewed Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SQL integration documentation to reflect a change where the query configuration parameter now accepts templates instead of plain strings. This aligns the documentation with the corresponding code change in Home Assistant core that enables template functionality for SQL queries.

Comment thread source/_integrations/sql.markdown
c0ffeeca7
c0ffeeca7 previously approved these changes Aug 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gjohansson-ST 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Aug 14, 2025
emontnemery
emontnemery previously requested changes Nov 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example of using a template in the query

@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Nov 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft November 6, 2025 09:55
@gjohansson-ST gjohansson-ST marked this pull request as ready for review November 6, 2025 12:25
@home-assistant home-assistant Bot requested a review from emontnemery November 6, 2025 12:25
@home-assistant home-assistant Bot added the parent-merged The parent PR has been merged already label Nov 6, 2025
c0ffeeca7
c0ffeeca7 reviewed Nov 7, 2025
View reviewed changes
Comment thread source/_integrations/sql.markdown Outdated
c0ffeeca7
c0ffeeca7 approved these changes Nov 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gjohansson-ST 👍

@c0ffeeca7 c0ffeeca7 dismissed emontnemery’s stale review November 7, 2025 04:19

Example has been added.

@c0ffeeca7 c0ffeeca7 merged commit 67e570a into next Nov 7, 2025
9 checks passed
@home-assistant home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Nov 7, 2025
@c0ffeeca7 c0ffeeca7 deleted the gj-20250808-01 branch November 7, 2025 04:20
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gjohansson-ST @emontnemery @c0ffeeca7