-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notification texts in Bring #37395
Update notification texts in Bring #37395
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request updates the Bring! integration documentation for Home Assistant. The modifications refine the descriptions used for data attributes and notification types. Specifically, the description for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/bring.markdown (1)
92-92
: Nitpick: Remove Excessive Blank LinesStatic analysis indicates multiple consecutive blank lines on this line. For improved readability and consistency with markdown guidelines (MD012), please reduce them to a single blank line.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
92-92: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/bring.markdown
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/bring.markdown
92-92: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
🔇 Additional comments (2)
source/_integrations/bring.markdown (2)
86-91
: Clarify Updated Data Attribute DescriptionThe description for the
item
attribute has been updated from "Article name to include in the message" to "Item to include in the message." This change improves clarity by emphasizing that any item (not just an "article") can be used. Please verify that all related documentation sections (e.g., example notifications) consistently reference the updated terminology.
95-101
: Verify Updated Notification Type TextsThe texts for the notification types have been rephrased for improved clarity. In particular:
going_shopping
now reads "I'm going shopping! - Last chance for adjustments."urgent_message
now reads "Attention! Attention! - We still urgently need:[Items]
."These updates provide a more direct and contextual description of each notification. Please confirm that the new wording aligns with the app’s behavior and any related notifications described later in the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tr4nt0r 👍
Proposed change
Updates the notification texts to match the latest version of the Bring app. It was already updated in Home Assistant core. Also added some additional notes.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit