Vicare dhw schedule service #37364
Vicare dhw schedule service #37364
Conversation
CrEaK
requested review from
starkillerOG,
Jc2k,
balloob,
zweckj,
davet2001 and
bdraco
as code owners
home-assistant
bot
added
has-parent
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes introduce a new action, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (10)
source/more-info/backup-emergency-kit.markdown (2)
26-28: Clarify Backup Encryption Key Management.
The added bullet points effectively explain that Home Assistant tracks the current encryption key (allowing on-the-fly decryption) and highlights that if the key has been changed, the old key is still required. Consider rephrasing “in the meantime” to a more succinct alternative for improved clarity.🧰 Tools
🪛 LanguageTool
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
43-46: Refine Language for Decryption Details.
In the statement “Home Assistant can not decrypt it on the fly” (line 46), please change “can not” to “cannot” for better readability and consistency. A suggested change is below:
diff - Home Assistant can not decrypt it on the fly. + Home Assistant cannot decrypt it on the fly.🧰 Tools
🪛 LanguageTool
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...(CAN_NOT_PREMIUM)
source/_integrations/onedrive.markdown (1)
66-68: Remove Trailing Spaces for Better Markdown Linting.
Static analysis detected trailing spaces on these lines. Removing them will help maintain consistency with markdown guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
66-66: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
68-68: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
source/_integrations/squeezebox.markdown (1)
99-140: Enhanced YAML Parameter Formatting InstructionsThe documentation now clearly explains that when using the Visual Editor, each additional parameter must be preceded by a hyphen and a space. The examples provided for toggling the muting state (lines 99–107 and 108–118) and for incrementing the playback volume (lines 119–127 and 128–140) are well laid out with corresponding YAML code blocks.
One minor nitpick: the parameter table for the mute example shows an empty row (Row 2). If this is not intentional, consider removing or clarifying the empty row to prevent potential confusion for users.
source/_dashboards/energy.markdown (1)
238-262: New Section: Using Multiple CollectionsA new section has been introduced to explain how to use the "collection_key" option for linking energy cards to distinct date selections. The detailed instructions—including the requirement that the key must begin with "energy_"—are clear and useful for advanced configuration scenarios.
One good-to-have suggestion: On the line stating,
“All energy cards support use ofcollection_keyoption.”
consider rephrasing it for clarity. For example, change it to:
“All energy cards support thecollection_keyoption.”Below is a diff suggestion for the rephrasing:
- All energy cards support the
collection_keyoption.
- All energy cards support use of
collection_keyoption.This adjustment should help eliminate the repeated verb phrasing flagged by the static analysis.
🧰 Tools
🪛 LanguageTool
[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use ofcollection_keyoption. ### Examples Example view with multiple collections: ```yam...(REPEATED_VERBS)
source/voice_control/troubleshooting.markdown (2)
95-101: Improve Markdown heading formatting for "Local Network Settings".The new heading at line 95 is not surrounded by blank lines, which violates markdownlint’s MD022 rule for headings. Please add a blank line before and after the heading to improve readability and comply with standards.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
95-95: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
107-109: Improve Markdown heading formatting for "Missing Media Source".Similarly, the "### Missing Media Source" heading should be preceded and followed by a blank line. This will resolve the markdownlint MD022 warning and enhance document clarity.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
107-107: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
source/_integrations/vicare.markdown (1)
121-129: Refine language and improve link formatting in the new ViCare action.The description for the new action “vicare.set_dhw_circulation_pump_schedule” reads “Set the schedule domestic hot water circulation pump as defined by Viessmann”. Consider inserting the preposition “for” to read “Set the schedule for the domestic hot water circulation pump as defined by Viessmann.”
Additionally, the bare URL in the example for thescheduleattribute (line 128) should be formatted as a markdown link to improve readability and compliance with the no-bare-URLs rule. For example:-| `schedule` | no | New schedule as json-string. Example of json-schema: https://www.postman.com/vimicho/viessmann-api-public/request/hpbagam/set-heating-schedule | +| `schedule` | no | New schedule as json-string. Example of json-schema: [Example Schema](https://www.postman.com/vimicho/viessmann-api-public/request/hpbagam/set-heating-schedule) |Consider applying these refinements.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...(AI_HYDRA_LEO_MISSING_OF)
🪛 markdownlint-cli2 (0.17.2)
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
128-128: Bare URL used
null(MD034, no-bare-urls)
source/_posts/2025-02-05-release-20252.markdown (1)
518-568: Clean up duplicate/unused link reference definitions.Static analysis indicates that several link and image reference definitions (e.g., for “#137448”, “@allenporter”, “@frenck”, “@gjohansson-ST”, “@starkillerOG”, and “@zweckj”) are either duplicated or unused. Cleaning these up will improve maintainability and reduce clutter in the markdown. Please review and remove any definitions that are not referenced in the document.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
518-518: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"(MD053, link-image-reference-definitions)
548-548: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"(MD053, link-image-reference-definitions)
557-557: Link and image reference definitions should be needed
Unused link or image reference definition: "@frenck"(MD053, link-image-reference-definitions)
558-558: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@gjohansson-ST"(MD053, link-image-reference-definitions)
563-563: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"(MD053, link-image-reference-definitions)
567-567: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"(MD053, link-image-reference-definitions)
source/changelogs/core-2025.2.markdown (1)
1395-1395: Remove Unused Link Reference Definition
Static analysis flagged an unused link or image reference definition (“#137448”). Please remove this unused reference to conform with Markdown linting (MD053).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
1395-1395: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"(MD053, link-image-reference-definitions)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Gemfile.lockis excluded by!**/*.lock
📒 Files selected for processing (20)
Gemfile(1 hunks)_config.yml(1 hunks)source/_dashboards/energy.markdown(1 hunks)source/_dashboards/statistics-graph.markdown(1 hunks)source/_includes/common-tasks/backups.md(1 hunks)source/_includes/site/footer.html(1 hunks)source/_integrations/bluetooth.markdown(1 hunks)source/_integrations/flexit_bacnet.markdown(1 hunks)source/_integrations/generic.markdown(1 hunks)source/_integrations/onedrive.markdown(3 hunks)source/_integrations/openai_conversation.markdown(1 hunks)source/_integrations/private_ble_device.markdown(1 hunks)source/_integrations/reolink.markdown(2 hunks)source/_integrations/squeezebox.markdown(1 hunks)source/_integrations/vicare.markdown(2 hunks)source/_posts/2025-02-05-release-20252.markdown(2 hunks)source/_redirects(1 hunks)source/changelogs/core-2025.2.markdown(1 hunks)source/more-info/backup-emergency-kit.markdown(2 hunks)source/voice_control/troubleshooting.markdown(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- Gemfile
🧰 Additional context used
📓 Path-based instructions (6)
`*/**(html|markdown|md)`: - For instructional content in doc...
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
source/_redirects
`*/**(html|markdown|md)`: - Use bold to mark UI strings. - I...
*/**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
source/_redirects
`*/**(html|markdown|md)`: - Be brief in your replies and don...
*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
source/_redirects
`*/**(html|markdown|md)`: - Use sentence-style capitalizatio...
*/**(html|markdown|md): - Use sentence-style capitalization also in headings.
source/_redirects
`*/**(html|markdown|md)`: do not comment on HTML used for ic...
*/**(html|markdown|md): do not comment on HTML used for icons
source/_redirects
`*/**(html|markdown|md)`: Avoid flagging inline HTML for emb...
*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.
source/_redirects
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/squeezebox.markdown
142-142: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
source/voice_control/troubleshooting.markdown
95-95: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
107-107: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
source/_posts/2025-02-05-release-20252.markdown
518-518: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
548-548: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"
(MD053, link-image-reference-definitions)
557-557: Link and image reference definitions should be needed
Unused link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
558-558: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@gjohansson-ST"
(MD053, link-image-reference-definitions)
563-563: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"
(MD053, link-image-reference-definitions)
567-567: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"
(MD053, link-image-reference-definitions)
source/_integrations/onedrive.markdown
66-66: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
68-68: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
source/_integrations/vicare.markdown
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
128-128: Bare URL used
null
(MD034, no-bare-urls)
source/changelogs/core-2025.2.markdown
1395-1395: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
🪛 LanguageTool
source/_dashboards/energy.markdown
[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use of collection_key option. ### Examples Example view with multiple collections: ```yam...
(REPEATED_VERBS)
source/more-info/backup-emergency-kit.markdown
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...
(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...
(CAN_NOT_PREMIUM)
source/_integrations/vicare.markdown
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...
(AI_HYDRA_LEO_MISSING_OF)
🔇 Additional comments (46)
source/_redirects (1)
12-13: LGTM! Social media redirects added correctly.The new redirects for Mastodon and Bluesky are properly placed in the "General use redirects" section and match the corresponding links in the footer.
source/_includes/site/footer.html (1)
88-88: LGTM! Social media links updated with consistent formatting.The changes maintain a consistent structure with other social media links:
- Line breaks added for better visual organization
- New Bluesky link follows the same pattern with
rel="me"attribute and iconAlso applies to: 95-100, 107-107
source/_integrations/flexit_bacnet.markdown (1)
26-27: Clarify Prerequisites Requirements.
The newly added lines clearly state that a Flexit device must have an ethernet port and that communication is carried out over BACnet. This concise detail helps users verify their hardware compatibility before setup.source/_integrations/onedrive.markdown (3)
2-3: Update Branding and Description.
Changing the title to “Microsoft OneDrive” and updating the description enhances clarity by explicitly referencing Microsoft’s service. This update minimizes potential confusion regarding the integration's scope.
19-20: Clarify Functionality for Backups.
The introductory line now clearly states that Microsoft OneDrive is used for Home Assistant Backups. This improves the integration’s documentation by directly linking the service to its backup functionality.
25-27: Explain Folder Naming Quirk Effectively.
The important block now explains that, due to issues in Microsoft’s APIs, the application folder may be namedGraphinstead ofHome Assistant, and it directs users to further details. This additional context is useful for troubleshooting and user expectations.source/_integrations/private_ble_device.markdown (1)
43-57: Enhance IRK Acquisition Instructions for Windows/Android.
The new “On Windows / For Android” section provides detailed and clear, step-by-step instructions for retrieving the Identity Resolving Key (IRK), including file paths, endianness considerations, and an alternative Wireshark approach. This added guidance is valuable for users working on different platforms.source/_dashboards/statistics-graph.markdown (1)
97-97: Improve Documentation for Multiple Date Selections.
The updated description for thecollection_keyoption now clearly explains its use withenergy_date_selectionand includes a reference to the relevant energy documentation. This helps users understand how to manage multiple date selection cards in a dashboard.source/_integrations/generic.markdown (1)
62-66: Updated Example for Weather GraphThe header and accompanying lines have been updated to showcase a new example using the USA National Weather Service. The example now clearly indicates that a GIF is displayed as the still image (line 64) and the URL in line 66 points to a valid radar image. Please verify that the example description accurately reflects what users will see and that the URL remains accessible.
_config.yml (1)
111-112: Patch Version and Release Date UpdateThe variables "current_patch_version" and "date_released" have been updated from 0 to 1 and from 2025-02-05 to 2025-02-07, respectively. These changes appear consistent with the documented release schedule. Ensure that the changelog and release notes are updated accordingly.
source/_integrations/openai_conversation.markdown (1)
136-137: Corrected Prompt String FormattingThe adjustment in the YAML automation example (line 136) removes an extraneous quotation mark from the prompt configuration. This correction ensures that the multi-line prompt string is syntactically valid within Home Assistant templating.
source/_includes/common-tasks/backups.md (1)
102-104: Clarification on on-the-fly decryption is clear.The updated statement explaining that downloads are decrypted on the fly when retrieving backups from any location (including Home Assistant Cloud) is clearly written and informative.
source/_integrations/bluetooth.markdown (1)
285-286: Addition for Shelly Gen2+ support is clear and useful.The new lines explicitly detailing that Shelly Gen2+ devices support both Bluetooth advertisement listening and bundling are a helpful enhancement to the documentation.
source/_posts/2025-02-05-release-20252.markdown (2)
74-76: TOC Update: New "Patch releases" entry is added.The table of contents now includes a new entry for “Patch releases,” which is clear and well-integrated into the overall release notes.
478-487: New Patch Releases section clarity and schedule.The newly introduced “Patch releases” section (starting at line 478) clearly outlines the intent to release bug fix patches every Friday and provides detailed release notes for version 2025.2.1 – February 7. This addition enhances transparency for end users regarding ongoing maintenance.
source/_integrations/reolink.markdown (1)
142-146: Clarification on Push Update Notation for Number EntitiesThe changes in these lines correctly update the listing to show a plus sign (+) next to the number entities (Image brightness, Image contrast, Image saturation, Image sharpness, Image hue), which clearly indicates that these entities now support push updates. This notation aligns well with the detailed explanation provided in the "Data updates: plus (+) next to entities listed in this documentation" section.
Action items:
- Verify that the default value of 128 is accurate and consistent with device settings.
- Ensure that the updated notation is uniformly applied across all similar entity listings if applicable.
source/changelogs/core-2025.2.markdown (30)
1361-1362: New Release Header Added
The header “## Release 2025.2.1 - February 7” clearly marks the new patch release and its effective date.
1363-1363: Fix Hassio Test Fixture Issue
This bullet notes the fix for using the wrong fixture in a hassio test. Verify that the new fixture is functioning as intended in all affected test cases.
1364-1364: Update Electric Kiwi Authentication
The change adjusts the authentication mechanism for Electric Kiwi. Please confirm that this update complies with security best practices and that any dependent components have been tested.
1365-1365: Update govee-ble to Version 0.42.1
This update brings govee-ble to v0.42.1. Note that a later bullet (line 1369) bumps govee-ble further to 0.43.0. Please verify whether v0.42.1 is an interim step or if v0.43.0 should completely supersede it.
1366-1366: Bump ‘holidays’ Library to 0.66
This dependency update is straightforward and should enhance compatibility with new features.
1367-1367: Bump aiohttp-asyncmdnsresolver to 0.1.0
This change modernizes the mDNS resolver integration. No issues found.
1368-1368: Bump aiohttp to 3.11.12
Upgrading aiohttp to 3.11.12 helps ensure better compatibility and stability.
1369-1369: Bump govee-ble to 0.43.0 for Firmware Compatibility
This update is intended to fix compatibility with the new H5179 firmware. As it follows the previous govee-ble update, please clarify if the update to 0.43.0 replaces the earlier version rather than coexisting.
1370-1370: Bump habiticalib to v0.3.5
The library update to habiticalib v0.3.5 should bring improvements and bug fixes.
1371-1371: Fix Mill Sensor Display Issue
This fix addresses the Mill integration bug where sensors were not shown. Ensure that this does not inadvertently affect other sensor-related behaviors.
1372-1372: Preserve Setup State in async_set_domains_to_be_loaded
Preventing unintended overwrites of the setup state is a needed correction, just verify that initialization remains smooth.
1373-1373: Use Separate Metadata Files for OneDrive
Separating metadata files should improve maintainability and clarity for the OneDrive integration.
1374-1374: Fix Sending Polls to Telegram Threads
This fix should resolve issues with polls being sent to Telegram thread conversations. Additional testing might be useful to ensure thread behavior remains intact.
1375-1375: Skip Building Wheels for electrickiwi-api
Omitting wheel builds for electrickiwi-api can simplify the build process if wheels are not needed for deployment.
1376-1376: Add Excluded Domains to Broadcast Intent
This addition refines broadcast intent behavior by excluding certain domains. Ensure that the list of excluded domains is well documented.
1377-1377: Revert PaddleSwitchPico Device Trigger for Lutron Caseta
The revert indicates that the previously added device trigger didn't work as expected. It would help to provide additional context or reference documentation so users understand the impact of this revert.
1378-1378: Fix Overseerr Webhook Configuration JSON
Correcting the JSON configuration for Overseerr webhooks will ensure proper integration functionality.
1379-1379: Avoid Reliance on pyserial in CM5 + ZHA Port Scanning
This change avoids potential pitfalls of using pyserial in port scanning for CM5 devices. Confirm that alternative methods are robust and well tested.
1380-1380: Bump eheimdigital to 1.0.6
This update should secure compatibility improvements in the eheimdigital integration.
1381-1381: Bump pyfireservicerota to 0.0.46
This update is straightforward and likely brings important bug fixes.
1382-1382: Bump reolink-aio to 0.11.10
This bump should resolve issues and improve performance for the Reolink integration.
1383-1383: Enhance MQTT Publish Action by Allowing Empty Payload
Allowing the payload attribute to be omitted (defaulting to an empty payload) improves usability in scenarios where an empty payload is required. Ensure that documentation is updated to explain this behavior.
1384-1384: Handle Previously Migrated HEOS Device Identifier
This fix ensures that devices that were migrated under an older scheme are correctly handled, which is important for user upgrades.
1385-1385: Bump aioshelly to Version 12.4.1
This update should keep the Shelly integrations current.
1386-1386: Bump electrickiwi-api to 0.9.13
This update reflects necessary improvements to the electrickiwi-api.
1387-1387: Bump ZHA to 0.0.48
Upgrading ZHA to 0.0.48 may solve existing integration issues; please test thoroughly.
1388-1388: Bump Electrickiwi-api to 0.9.14
This subsequent update for electrickiwi-api suggests further refinements. Please ensure that there is no conflict with the earlier update on line 1386.
1389-1389: Update google-nest-sdm to 7.1.3
This update should enhance functionality and compatibility with the latest Google Nest devices.
1390-1390: Correct Shelly BLU TRV Temperature Reporting
The change avoids using the current temperature from Shelly BLU TRV as the state for the External Temperature number entity. Confirm that this improves sensor accuracy.
1391-1391: Fix LG webOS TV Power-Off Handling
This fix prevents the TV from turning off if it is already off, ensuring correct behavior. Validate with a mix of real and simulated device states.
|
Hi @CrEaK thank you for the PR! There seem to be unrelated changes, please can you rebase or otherwise reduce the changes to be just related to the PR? Thanks! |
CrEaK
force-pushed
the
vicare_dhw_schedule_service
branch
from
9fa246d to
89bb580
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (13)
source/_integrations/vicare.markdown (1)
121-128: Enhance the new action description for clarity and markdown consistency.
For the newly added actionvicare.set_dhw_circulation_pump_schedule, consider the following improvements:
- On line 123 the description is missing a preposition; “Set the schedule domestic hot water circulation pump…” would be clearer as “Set the schedule for the domestic hot water circulation pump…”. Also, adding punctuation (a period) improves readability.
- On line 128 the bare URL is used. To comply with markdown best practices (and address the MD034 warning), wrap the URL in proper link formatting so that it appears as a clickable hyperlink.
Suggested diffs:
-Set the schedule domestic hot water circulation pump as defined by Viessmann +Set the schedule for the domestic hot water circulation pump as defined by Viessmann.and
-| `schedule` | no | New schedule as json-string. Example of json-schema: https://www.postman.com/vimicho/viessmann-api-public/request/hpbagam/set-heating-schedule | +| `schedule` | no | New schedule as a JSON string. Example of json-schema: [Viessmann heating schedule](https://www.postman.com/vimicho/viessmann-api-public/request/hpbagam/set-heating-schedule) |🧰 Tools
🪛 LanguageTool
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...(AI_HYDRA_LEO_MISSING_OF)
🪛 markdownlint-cli2 (0.17.2)
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
128-128: Bare URL used
null(MD034, no-bare-urls)
source/_integrations/squeezebox.markdown (1)
99-132: Documentation Enhancement: Parameter Specification Example
The new section clearly explains how to specify additional parameters in the Visual Editor – each parameter must be preceded by a hyphen and a space. The examples for muting playback and incrementing volume are very helpful for users. One minor suggestion is to review the table formatting (e.g. the second row is empty) to check if that cell is needed or if it could be omitted for clarity.source/_dashboards/energy.markdown (1)
237-254: New Section Clarity: Multiple Collections for Energy Cards
The added "Using Multiple Collections" section does a great job of explaining how to enable multiple date selections using thecollection_keyoption. It provides a clear rationale and a practical YAML example.
A small grammatical nitpick: on line 239, the phrase
“All energy cards support use ofcollection_keyoption.”
could be improved for clarity. It is recommended to change it to:
“All energy cards support the use of thecollection_keyoption.”
Below is a suggested diff for this change:-All energy cards support use of `collection_key` option. +All energy cards support the use of the `collection_key` option.🧰 Tools
🪛 LanguageTool
[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use ofcollection_keyoption. ### Examples Example view with multiple collections: ```yam...(REPEATED_VERBS)
source/more-info/backup-emergency-kit.markdown (3)
26-28: Refine phrasing for clarity regarding encryption key changes.The current bullet point uses the phrase “in the meantime,” which can be simplified. Consider removing “in the meantime” to make the instruction more concise and direct.
[style]Proposed diff:
- - But if you have changed the encryption key in the meantime, you still need the old key that matches old backups. + - But if you have changed the encryption key, you still need the old key that matches old backups.🧰 Tools
🪛 LanguageTool
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
43-44: Clarify instructions for re-downloading the encryption key.This new line informs users that they can download the encryption key from the backup settings if they still have access to their Home Assistant instance. If applicable, consider adding a direct link to the backup settings page for enhanced usability.
45-46: Standardize language in describing decryption capability.The text “can not decrypt” should be replaced with “cannot decrypt” for improved readability and consistency according to modern usage.
[style]Proposed diff:
-**If you have changed the encryption key**: Home Assistant can not decrypt it on the fly. +**If you have changed the encryption key**: Home Assistant cannot decrypt it on the fly.🧰 Tools
🪛 LanguageTool
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...(CAN_NOT_PREMIUM)
source/voice_control/troubleshooting.markdown (2)
95-106: Markdown Formatting: Blank Lines Around "Local Network Settings" Heading
Static analysis indicates that headings should be surrounded by blank lines (MD022). To conform to the Home Assistant documentation standards, please insert a blank line before and after the "### Local Network Settings" heading.Proposed diff:
- + +### Local Network SettingsEnsure that there is also a blank line after the heading if not already present.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
95-95: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
103-103: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
104-104: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
104-104: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
107-109: Markdown Formatting: Blank Lines Around "Missing Media Source" Heading
Similarly, the "### Missing Media Source" heading should be surrounded by blank lines to meet markdown standards (MD022). Please add a blank line before and after this heading.Proposed diff:
-106 +106 + +### Missing Media Source + +If you are using YAML configuration and do not have `default_config:` make sure `media_source:` is present.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
107-107: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
source/_integrations/onedrive.markdown (1)
64-70: New Section on Backup Folder Naming: Detail and Formatting
The new “## Backup folder is calledGraph” section is very informative, explaining how folder naming works when Microsoft’s Graph API is involved. One suggestion: please review the formatting to ensure consistency—specifically, consider removing any trailing spaces that were noted by static analysis (e.g. on lines 66 and 68). For example, you might apply a diff such as:-This integration uses Microsoft's Graph API to communicate with your OneDrive. Because of an [issue](https://github.com/OneDrive/onedrive-api-docs/issues/1866) in that API, the application folder is often not named with the name of the application (`Home Assistant`), but `Graph` instead.␣ +This integration uses Microsoft's Graph API to communicate with your OneDrive. Because of an [issue](https://github.com/OneDrive/onedrive-api-docs/issues/1866) in that API, the application folder is often not named with the name of the application (`Home Assistant`), but `Graph` instead.This is a minor formatting adjustment and does not affect functionality.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
66-66: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
68-68: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
source/_integrations/private_ble_device.markdown (1)
43-57: New Section for Windows/Android IRK Retrieval: Heading Clarification
The added “### On Windows / For Android” section provides detailed instructions for obtaining the Identity Resolving Key (IRK) on Android (using a rooted phone and via Wireshark). However, the heading mentions “Windows” while the content focuses exclusively on Android. Consider clarifying the heading to accurately reflect the content (or add Windows-specific instructions if available) to avoid confusion for users.source/_posts/2025-02-05-release-20252.markdown (1)
518-567: Markdown References: Remove Duplicates/Unused Definitions
Static analysis flagged several issues with link and image reference definitions between lines 518 and 567 (e.g. duplicate entries for “@allenporter”, “@gjohansson-ST”, “@starkillerOG”, “@zweckj”, and an unused reference “#137448”). Please review these definitions and remove any duplicates or unused references to improve the clarity and maintainability of the markdown document.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
518-518: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"(MD053, link-image-reference-definitions)
548-548: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"(MD053, link-image-reference-definitions)
557-557: Link and image reference definitions should be needed
Unused link or image reference definition: "@frenck"(MD053, link-image-reference-definitions)
558-558: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@gjohansson-ST"(MD053, link-image-reference-definitions)
563-563: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"(MD053, link-image-reference-definitions)
567-567: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"(MD053, link-image-reference-definitions)
source/changelogs/core-2025.2.markdown (2)
1361-1392: New Release Section Added
The new release notes for Home Assistant Core 2025.2.1 are comprehensive and clearly list the various fixes, version bumps, and reverts. The bullet points are concise and reference the corresponding PRs, which helps trace each change back to its origin. Please double-check that all version numbers (e.g. for govee-ble, holidays, aiohttp, etc.) match the actual updates in the code and that the change details are reflected accurately in other documentation.
1395-1395: Unused Reference Link Definition
The static analysis tool reports an unused reference link labeled “#137448”. If this reference is not being used within the document, consider removing it to tidy up the markdown and avoid potential confusion.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
1395-1395: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"(MD053, link-image-reference-definitions)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Gemfile.lockis excluded by!**/*.lock
📒 Files selected for processing (20)
Gemfile(1 hunks)_config.yml(1 hunks)source/_dashboards/energy.markdown(1 hunks)source/_dashboards/statistics-graph.markdown(1 hunks)source/_includes/common-tasks/backups.md(1 hunks)source/_includes/site/footer.html(1 hunks)source/_integrations/bluetooth.markdown(1 hunks)source/_integrations/flexit_bacnet.markdown(1 hunks)source/_integrations/generic.markdown(1 hunks)source/_integrations/onedrive.markdown(3 hunks)source/_integrations/openai_conversation.markdown(1 hunks)source/_integrations/private_ble_device.markdown(1 hunks)source/_integrations/reolink.markdown(2 hunks)source/_integrations/squeezebox.markdown(1 hunks)source/_integrations/vicare.markdown(2 hunks)source/_posts/2025-02-05-release-20252.markdown(2 hunks)source/_redirects(1 hunks)source/changelogs/core-2025.2.markdown(1 hunks)source/more-info/backup-emergency-kit.markdown(2 hunks)source/voice_control/troubleshooting.markdown(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (11)
- source/_includes/common-tasks/backups.md
- source/_integrations/flexit_bacnet.markdown
- source/_integrations/openai_conversation.markdown
- _config.yml
- source/_integrations/generic.markdown
- source/_includes/site/footer.html
- source/_redirects
- Gemfile
- source/_dashboards/statistics-graph.markdown
- source/_integrations/reolink.markdown
- source/_integrations/bluetooth.markdown
🧰 Additional context used
🪛 LanguageTool
source/_dashboards/energy.markdown
[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use of collection_key option. ### Examples Example view with multiple collections: ```yam...
(REPEATED_VERBS)
source/_integrations/vicare.markdown
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...
(AI_HYDRA_LEO_MISSING_OF)
source/more-info/backup-emergency-kit.markdown
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...
(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...
(CAN_NOT_PREMIUM)
🪛 markdownlint-cli2 (0.17.2)
source/changelogs/core-2025.2.markdown
1395-1395: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
source/_integrations/onedrive.markdown
66-66: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
68-68: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
source/_integrations/squeezebox.markdown
142-142: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
source/_integrations/vicare.markdown
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
128-128: Bare URL used
null
(MD034, no-bare-urls)
source/_posts/2025-02-05-release-20252.markdown
518-518: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
548-548: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"
(MD053, link-image-reference-definitions)
557-557: Link and image reference definitions should be needed
Unused link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
558-558: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@gjohansson-ST"
(MD053, link-image-reference-definitions)
563-563: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"
(MD053, link-image-reference-definitions)
567-567: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"
(MD053, link-image-reference-definitions)
source/voice_control/troubleshooting.markdown
95-95: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
107-107: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🔇 Additional comments (7)
source/_integrations/vicare.markdown (1)
110-110: Remove extraneous punctuation in the water_heater action description.
The description still shows an extra comma and stray backticks aroundset_temperaturewhich can be misinterpreted.
[refactor_suggestion_nitpick]
Consider applying the following diff:-The following actions of the [water_heater integration](/integrations/water_heater/) are provided by the ViCare integration: `set_temperature', `` +The following actions of the [water_heater integration](/integrations/water_heater/) are provided by the ViCare integration: `set_temperature`source/more-info/backup-emergency-kit.markdown (1)
38-38: Clear and concise instruction for generating a new encryption key.The step properly instructs users to select Next and then Change encryption key which aligns with typical UI flows.
source/voice_control/troubleshooting.markdown (1)
1-94: Unrelated Documentation Updates Detected
It appears that this file—focused on troubleshooting for Assist—is being updated with new sections ("Local Network Settings" and "Missing Media Source"). However, the PR objectives mention a new service for configuring the circulation pump schedule. Please confirm if these troubleshooting documentation changes are intentionally included in this PR or if they were added by mistake.🧰 Tools
🪛 LanguageTool
[uncategorized] ~32-~32: Consider adding a hyphen.
Context: ...ew](#view-debug-information). 2. In the top right corner, select the icon. 
|
@davet2001 Fixed the history now. Sorry for that! |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
source/_integrations/vicare.markdown (3)
121-129: Review new action “vicare.set_dhw_circulation_pump_schedule”.
The addition of this new action is clearly documented with a header and a data attribute table. The table specifies the optional “entity_id” and the required “schedule” (as a JSON string), which aligns with the new feature.A couple of minor suggestions:
- Consider ensuring that the description fully explains the expected JSON format for clarity.
- The static analysis noted a bare URL and trailing whitespace (see subsequent comments).
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
128-128: Bare URL used
null(MD034, no-bare-urls)
123-123: Remove trailing whitespace.
Static analysis indicates that line 123 ends with extra spaces. Removing them will improve markdown consistency.Proposed Diff:
-Set the schedule domestic hot water circulation pump as defined by Viessmann␣␣ +Set the schedule domestic hot water circulation pump as defined by Viessmann🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
128-128: Convert bare URL to a markdown link.
Line 128 directly uses a bare URL for the JSON schema example. For better readability and adherence to markdown best practices, consider embedding the URL as a link with descriptive text.Proposed Diff:
-| `schedule` | no | New schedule as json-string. Example of json-schema: https://www.postman.com/vimicho/viessmann-api-public/request/hpbagam/set-heating-schedule | +| `schedule` | no | New schedule as json-string. Example of json-schema: [See JSON schema](https://www.postman.com/vimicho/viessmann-api-public/request/hpbagam/set-heating-schedule) |🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
128-128: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/vicare.markdown(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/vicare.markdown
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
128-128: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/vicare.markdown (1)
121-129: Improve the description for the DHW circulation pump schedule action.
The current description reads "Set the schedule domestic hot water circulation pump as defined by Viessmann" and is missing the preposition "for." Revising it to "Set the schedule for the domestic hot water circulation pump as defined by Viessmann" will improve clarity. Additionally, please remove any trailing spaces.
Proposed change:-Set the schedule domestic hot water circulation pump as defined by Viessmann +Set the schedule for the domestic hot water circulation pump as defined by Viessmann🧰 Tools
🪛 LanguageTool
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...(AI_HYDRA_LEO_MISSING_OF)
🪛 markdownlint-cli2 (0.17.2)
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/vicare.markdown(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/vicare.markdown
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...
(AI_HYDRA_LEO_MISSING_OF)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/vicare.markdown
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
🔇 Additional comments (1)
source/_integrations/vicare.markdown (1)
110-110: Remove extraneous apostrophe from water_heater action description.
The inline code for theset_temperatureaction in the water_heater integration still shows an extra apostrophe. Removing it will ensure the documentation is correctly formatted.
Proposed change:-The following actions of the [water_heater integration](/integrations/water_heater/) are provided by the ViCare integration: `set_temperature' +The following actions of the [water_heater integration](/integrations/water_heater/) are provided by the ViCare integration: `set_temperature`
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/vicare.markdown (2)
121-124: Add missing preposition in the description.The description should include the preposition "for" to improve readability.
Apply this diff:
-Set the schedule domestic hot water circulation pump as defined by Viessmann +Set the schedule for the domestic hot water circulation pump as defined by Viessmann🧰 Tools
🪛 LanguageTool
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...(AI_HYDRA_LEO_MISSING_OF)
🪛 markdownlint-cli2 (0.17.2)
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
127-128: Improve the schedule example format.The JSON example makes the line very long and hard to read. Consider moving it to a dedicated code block section.
Apply this diff:
-| `schedule` | no | New schedule as json-string. (e.g. `{"mon":[{"start":"08:00","end":"22:00","mode":"on","position":0}],"tue":[{"start":"08:00","end":"22:00","mode":"on","position":0}],"wed":[{"start":"08:00","end":"22:00","mode":"on","position":0}],"thu":[{"start":"08:00","end":"22:00","mode":"on","position":0}],"fri":[{"start":"08:00","end":"22:00","mode":"on","position":0}],"sat":[{"start":"07:30","end":"22:00","mode":"on","position":0}],"sun":[{"start":"07:30","end":"22:00","mode":"on","position":0}]}`) | +| `schedule` | no | New schedule as json-string. See example below. | + +Example schedule: +```json +{ + "mon": [{"start": "08:00", "end": "22:00", "mode": "on", "position": 0}], + "tue": [{"start": "08:00", "end": "22:00", "mode": "on", "position": 0}], + "wed": [{"start": "08:00", "end": "22:00", "mode": "on", "position": 0}], + "thu": [{"start": "08:00", "end": "22:00", "mode": "on", "position": 0}], + "fri": [{"start": "08:00", "end": "22:00", "mode": "on", "position": 0}], + "sat": [{"start": "07:30", "end": "22:00", "mode": "on", "position": 0}], + "sun": [{"start": "07:30", "end": "22:00", "mode": "on", "position": 0}] +} +```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/vicare.markdown(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/vicare.markdown
[uncategorized] ~123-~123: Possible missing preposition found.
Context: ...lation_pump_schedule` Set the schedule domestic hot water circulation pump as defined b...
(AI_HYDRA_LEO_MISSING_OF)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/vicare.markdown
123-123: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/vicare.markdown (1)
118-118: LGTM!The description of the
entity_idparameter has been updated to use consistent formatting and clearer wording.
Removed the round brackets
Added documentation of the "remove" action which is present in the shopping_list_updated event that is fired when an item is removed from the list. This was not present before (only add and update were).
- to reflect current software - using keywords as described in https://www.home-assistant.io/dashboards/actions/#action
CrEaK
force-pushed
the
vicare_dhw_schedule_service
branch
2 times, most recently
from
4313da9 to
f63b27d
Compare
CrEaK
force-pushed
the
vicare_dhw_schedule_service
branch
from
f63b27d to
daf600d
Compare
Co-authored-by: Abílio Costa <[email protected]>
…K/home-assistant.io into vicare_dhw_schedule_service
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
source/_dashboards/energy.markdown (1)
244-246: Fix formatting and wording.
- Add a blank line before the "Examples" heading
- Remove redundant "Example" text to improve readability
Apply this diff:
All energy cards support use of `collection_key` option. ### Examples - Example view with multiple collections: + View with multiple collections:🧰 Tools
🪛 LanguageTool
[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use ofcollection_keyoption. ### Examples Example view with multiple collections: ```yam...(REPEATED_VERBS)
🪛 markdownlint-cli2 (0.17.2)
244-244: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
source/_integrations/squeezebox.markdown (1)
142-142: Remove extra blank line.There are multiple consecutive blank lines. Please remove one blank line to maintain consistent formatting.
- - +🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
142-142: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
source/more-info/backup-emergency-kit.markdown (2)
26-28: Improve clarity of encryption key explanation.The technical content is accurate and valuable. However, the phrasing can be more concise.
Consider this revision for improved clarity:
- - Home Assistant keeps track of the current encryption key. If you download from Home Assistant, it can decrypt your backup. - - But if you have changed the encryption key in the meantime, you still need the old key that matches old backups. + - Home Assistant keeps track of the current encryption key and can decrypt your backups when downloaded. + - If you've changed the encryption key, you'll need the previous key to decrypt older backups.🧰 Tools
🪛 LanguageTool
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
43-46: Fix grammar in key retrieval section.The content effectively explains the key retrieval scenarios, but needs minor grammar improvements.
Apply these grammar fixes:
-If you still have access to your Home Assistant instance you can download the encryption key again from the backup settings. +If you still have access to your Home Assistant instance, you can download the encryption key again from the backup settings. -Home Assistant can not decrypt it on the fly. +Home Assistant cannot decrypt it on the fly.🧰 Tools
🪛 LanguageTool
[uncategorized] ~43-~43: Possible missing comma found.
Context: ...till have access to your Home Assistant instance you can download the encryption key aga...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...(CAN_NOT_PREMIUM)
source/_integrations/season.markdown (1)
34-34: Improve sentence readability with proper punctuation.The sentence could benefit from better punctuation to improve clarity.
Apply this diff to improve readability:
-To cut a long read short, Astronomical gives seasons based on the shortest/longest day and equinoxes. So in the Northern Hemisphere spring starts on 20 March. Meteorological gives seasons based on months so in the Northern Hemisphere spring starts on 1 March. +To cut a long read short, Astronomical gives seasons based on the shortest/longest day and equinoxes, so in the Northern Hemisphere spring starts on 20 March. Meteorological gives seasons based on months, so in the Northern Hemisphere spring starts on 1 March.🧰 Tools
🪛 LanguageTool
[uncategorized] ~34-~34: Possible missing comma found.
Context: ...t day and equinoxes. So in the Northern Hemisphere spring starts on 20 March. Meteorologic...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~34-~34: A comma might be missing here.
Context: .... Meteorological gives seasons based on months so in the Northern Hemisphere spring st...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
source/_integrations/flick_electric.markdown (1)
104-104: Simplify the polling description.The sentence contains redundant verbs with "polling poll".
Apply this diff to improve readability:
-The integration will {% term polling poll %} the Flick Electric API every 5 minutes to check for the current power price. +The integration {% term polling polls %} the Flick Electric API every 5 minutes to check for the current power price.🧰 Tools
🪛 LanguageTool
[grammar] ~104-~104: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...a updates The integration will {% term polling poll %} the Flick Electric API every 5 minut...(REPEATED_VERBS)
source/changelogs/core-2025.2.markdown (1)
1477-3056: Clean up link references.There are some issues with the link references section:
- Duplicate link definitions for some authors and PRs
- Unused link references (#137448, #137688)
Clean up the link references by:
- Removing duplicate link definitions
- Removing unused link references
- Ensuring all references are used in the changelog
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
1479-1479: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#137448"(MD053, link-image-reference-definitions)
1481-1481: Link and image reference definitions should be needed
Unused link or image reference definition: "#137688"(MD053, link-image-reference-definitions)
1510-1510: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"(MD053, link-image-reference-definitions)
1511-1511: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@andrewsayre"(MD053, link-image-reference-definitions)
1514-1514: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"(MD053, link-image-reference-definitions)
1515-1515: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bieniu"(MD053, link-image-reference-definitions)
1517-1517: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@cdce8p"(MD053, link-image-reference-definitions)
1520-1520: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@emontnemery"(MD053, link-image-reference-definitions)
1521-1521: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"(MD053, link-image-reference-definitions)
1526-1526: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@thecode"(MD053, link-image-reference-definitions)
1527-1527: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tr4nt0r"(MD053, link-image-reference-definitions)
1529-1529: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"(MD053, link-image-reference-definitions)
2884-2884: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@Danielhiversen"(MD053, link-image-reference-definitions)
2892-2892: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@IceBotYT"(MD053, link-image-reference-definitions)
2922-2922: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@TheJulianJES"(MD053, link-image-reference-definitions)
2928-2928: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@abmantis"(MD053, link-image-reference-definitions)
2930-2930: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"(MD053, link-image-reference-definitions)
2932-2932: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@andrewsayre"(MD053, link-image-reference-definitions)
2934-2934: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@arturpragacz"(MD053, link-image-reference-definitions)
2938-2938: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@autinerd"(MD053, link-image-reference-definitions)
2939-2939: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@balloob"(MD053, link-image-reference-definitions)
2940-2940: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"(MD053, link-image-reference-definitions)
2942-2942: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bieniu"(MD053, link-image-reference-definitions)
2946-2946: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bramkragten"(MD053, link-image-reference-definitions)
2948-2948: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@cdce8p"(MD053, link-image-reference-definitions)
2954-2954: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@dan-r"(MD053, link-image-reference-definitions)
2961-2961: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@dknowles2"(MD053, link-image-reference-definitions)
2970-2970: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@emontnemery"(MD053, link-image-reference-definitions)
2977-2977: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"(MD053, link-image-reference-definitions)
2980-2980: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@gjohansson-ST"(MD053, link-image-reference-definitions)
2992-2992: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@jbouwh"(MD053, link-image-reference-definitions)
2997-2997: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@jpbede"(MD053, link-image-reference-definitions)
3015-3015: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@mib1185"(MD053, link-image-reference-definitions)
3019-3019: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@natekspencer"(MD053, link-image-reference-definitions)
3025-3025: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@puddly"(MD053, link-image-reference-definitions)
3044-3044: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"(MD053, link-image-reference-definitions)
3045-3045: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@synesthesiam"(MD053, link-image-reference-definitions)
3046-3046: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@thecode"(MD053, link-image-reference-definitions)
3051-3051: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tr4nt0r"(MD053, link-image-reference-definitions)
3052-3052: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tronikos"(MD053, link-image-reference-definitions)
3056-3056: Files should end with a single newline character
null(MD047, single-trailing-newline)
3056-3056: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"(MD053, link-image-reference-definitions)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Gemfile.lockis excluded by!**/*.locksource/images/integrations/onedrive/onedrive-app-registration.pngis excluded by!**/*.png
📒 Files selected for processing (35)
Gemfile(1 hunks)_config.yml(1 hunks)source/_dashboards/conditional.markdown(2 hunks)source/_dashboards/energy.markdown(1 hunks)source/_dashboards/statistics-graph.markdown(1 hunks)source/_includes/common-tasks/backups.md(1 hunks)source/_includes/custom/buy-dialog.html(1 hunks)source/_includes/site/footer.html(1 hunks)source/_integrations/bluetooth.markdown(1 hunks)source/_integrations/bring.markdown(3 hunks)source/_integrations/flexit_bacnet.markdown(1 hunks)source/_integrations/flick_electric.markdown(1 hunks)source/_integrations/foscam.markdown(8 hunks)source/_integrations/generic.markdown(1 hunks)source/_integrations/motioneye.markdown(1 hunks)source/_integrations/onedrive.markdown(4 hunks)source/_integrations/openai_conversation.markdown(1 hunks)source/_integrations/private_ble_device.markdown(1 hunks)source/_integrations/reolink.markdown(2 hunks)source/_integrations/season.markdown(1 hunks)source/_integrations/shopping_list.markdown(1 hunks)source/_integrations/slack.markdown(2 hunks)source/_integrations/squeezebox.markdown(1 hunks)source/_integrations/telegram.markdown(2 hunks)source/_integrations/telegram_bot.markdown(3 hunks)source/_integrations/tesla_fleet.markdown(3 hunks)source/_integrations/vicare.markdown(2 hunks)source/_posts/2025-02-05-release-20252.markdown(2 hunks)source/_redirects(1 hunks)source/changelogs/core-2025.2.markdown(1 hunks)source/dashboards/badges.markdown(1 hunks)source/dashboards/cards.markdown(3 hunks)source/installation/raspberrypi.markdown(1 hunks)source/more-info/backup-emergency-kit.markdown(2 hunks)source/voice_control/troubleshooting.markdown(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (23)
- source/_integrations/private_ble_device.markdown
- Gemfile
- source/_includes/common-tasks/backups.md
- source/_integrations/flexit_bacnet.markdown
- source/_integrations/tesla_fleet.markdown
- source/installation/raspberrypi.markdown
- source/_integrations/openai_conversation.markdown
- source/_integrations/shopping_list.markdown
- source/dashboards/cards.markdown
- source/_dashboards/statistics-graph.markdown
- source/_dashboards/conditional.markdown
- source/_integrations/foscam.markdown
- source/_integrations/telegram.markdown
- source/dashboards/badges.markdown
- source/_includes/site/footer.html
- source/_integrations/motioneye.markdown
- source/_integrations/generic.markdown
- source/_redirects
- source/_includes/custom/buy-dialog.html
- _config.yml
- source/_integrations/bluetooth.markdown
- source/_integrations/slack.markdown
- source/_integrations/reolink.markdown
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/onedrive.markdown
68-68: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
75-75: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
77-77: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
source/_integrations/bring.markdown
32-32: Trailing punctuation in heading
Punctuation: '!'
(MD026, no-trailing-punctuation)
97-97: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
151-151: Bare URL used
null
(MD034, no-bare-urls)
source/_posts/2025-02-05-release-20252.markdown
519-519: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
549-549: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"
(MD053, link-image-reference-definitions)
558-558: Link and image reference definitions should be needed
Unused link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
559-559: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@gjohansson-ST"
(MD053, link-image-reference-definitions)
564-564: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"
(MD053, link-image-reference-definitions)
568-568: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"
(MD053, link-image-reference-definitions)
603-603: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
605-605: Link and image reference definitions should be needed
Unused link or image reference definition: "#137688"
(MD053, link-image-reference-definitions)
634-634: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"
(MD053, link-image-reference-definitions)
635-635: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@andrewsayre"
(MD053, link-image-reference-definitions)
638-638: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"
(MD053, link-image-reference-definitions)
639-639: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bieniu"
(MD053, link-image-reference-definitions)
641-641: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@cdce8p"
(MD053, link-image-reference-definitions)
644-644: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@emontnemery"
(MD053, link-image-reference-definitions)
645-645: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
650-650: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@thecode"
(MD053, link-image-reference-definitions)
651-651: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tr4nt0r"
(MD053, link-image-reference-definitions)
652-652: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tronikos"
(MD053, link-image-reference-definitions)
653-653: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"
(MD053, link-image-reference-definitions)
source/changelogs/core-2025.2.markdown
1395-1395: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
1479-1479: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#137448"
(MD053, link-image-reference-definitions)
1481-1481: Link and image reference definitions should be needed
Unused link or image reference definition: "#137688"
(MD053, link-image-reference-definitions)
1510-1510: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@allenporter"
(MD053, link-image-reference-definitions)
1511-1511: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@andrewsayre"
(MD053, link-image-reference-definitions)
1514-1514: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"
(MD053, link-image-reference-definitions)
1515-1515: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bieniu"
(MD053, link-image-reference-definitions)
1517-1517: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@cdce8p"
(MD053, link-image-reference-definitions)
1520-1520: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@emontnemery"
(MD053, link-image-reference-definitions)
1521-1521: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
1526-1526: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@thecode"
(MD053, link-image-reference-definitions)
1527-1527: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tr4nt0r"
(MD053, link-image-reference-definitions)
1529-1529: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@zweckj"
(MD053, link-image-reference-definitions)
source/_dashboards/energy.markdown
244-244: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
source/_integrations/squeezebox.markdown
142-142: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
source/voice_control/troubleshooting.markdown
95-95: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
107-107: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🪛 LanguageTool
source/_integrations/bring.markdown
[formatting] ~211-~211: These punctuation marks differ from each other. Use only one if you are ending a sentence.
Context: ...net connection to communicate with Bring!. If you encounter issues, verify that yo...
(DOUBLE_PUNCTUATION_PREMIUM)
[style] ~211-~211: Using many exclamation marks might seem excessive (in this case: 38 exclamation marks for a text that’s 8700 characters long)
Context: ...ction is stable. Additionally, the Bring! service itself may experience downtime,...
(EN_EXCESSIVE_EXCLAMATION)
source/_integrations/flick_electric.markdown
[grammar] ~104-~104: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...a updates The integration will {% term polling poll %} the Flick Electric API every 5 minut...
(REPEATED_VERBS)
[style] ~122-~122: As a shorter alternative for ‘able to’, consider using “can not”.
Context: ...egration. If your account is active but is not able to be selected, check with Flick Electric ...
(BE_ABLE_TO)
[style] ~122-~122: Avoid the passive voice after ‘to be able to’.
Context: ...ur account is active but is not able to be selected, check with Flick Electric to ensure th...
(ABLE_TO_PASSIVE)
source/_posts/2025-02-05-release-20252.markdown
[uncategorized] ~75-~75: Commas set off the year in a month-day-year date.
Context: ...eases](#patch-releases) - 2025.2.1 - February 7 - [2025.2.2 - ...
(MISSING_COMMA_BETWEEN_DAY_AND_YEAR)
source/_dashboards/energy.markdown
[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use of collection_key option. ### Examples Example view with multiple collections: ```yam...
(REPEATED_VERBS)
source/_integrations/season.markdown
[uncategorized] ~34-~34: Possible missing comma found.
Context: ...t day and equinoxes. So in the Northern Hemisphere spring starts on 20 March. Meteorologic...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~34-~34: A comma might be missing here.
Context: .... Meteorological gives seasons based on months so in the Northern Hemisphere spring st...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
source/more-info/backup-emergency-kit.markdown
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...
(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
[uncategorized] ~43-~43: Possible missing comma found.
Context: ...till have access to your Home Assistant instance you can download the encryption key aga...
(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...
(CAN_NOT_PREMIUM)
🔇 Additional comments (31)
source/_dashboards/energy.markdown (2)
237-243: LGTM! Clear and accurate explanation of multiple collections.The explanation of
collection_keyusage and its requirements is well-written and technically accurate.
247-261: LGTM! Well-structured example with helpful comments.The YAML example clearly demonstrates how to:
- Configure multiple date selection cards
- Link energy cards to specific date selections using
collection_key- Use the default collection (without
collection_key)source/_integrations/squeezebox.markdown (2)
99-140: LGTM! Well-structured documentation with clear examples.The added documentation provides clear instructions and examples for using the Visual Editor with the Squeezebox integration. The examples effectively demonstrate parameter formatting and special cases like increment values.
1-159: Changes appear unrelated to PR objectives.The PR objectives describe documenting a new service for configuring circulation pump schedules. However, these changes are about documenting parameter usage in the Squeezebox integration's Visual Editor. Please verify if these changes should be part of this PR or if they should be submitted in a separate PR.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
83-83: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
84-84: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
85-85: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
142-142: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
151-151: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
152-152: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
153-153: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
source/more-info/backup-emergency-kit.markdown (1)
38-38: LGTM!Clear and concise instruction for generating a new encryption key.
source/_integrations/flick_electric.markdown (4)
21-32: LGTM! Clear and well-structured configuration parameters.The configuration parameters are well-documented with clear descriptions.
34-42: LGTM! Improved clarity about client credentials.The note about client ID/secret is clearer and more user-friendly, emphasizing that most users can leave these blank.
44-49: LGTM! Clear description of supported functionality.The functionality section clearly explains what the integration provides.
81-100: LGTM! Well-structured example automation.The example automation is clear and practical, demonstrating a real-world use case.
source/_integrations/onedrive.markdown (4)
2-2: LGTM! Improved branding consistency.The title and description now consistently use "Microsoft OneDrive" branding.
Also applies to: 19-19
73-79: LGTM! Clear explanation of folder naming behavior.The section clearly explains the reason for the "Graph" folder name and its behavior with multiple applications.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
75-75: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
77-77: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
57-65: LGTM! Important prerequisite information.The tip about Azure tenant requirements is crucial for users wanting to create custom credentials.
93-95: LGTM! Helpful troubleshooting information.The troubleshooting section provides clear guidance for common issues.
source/voice_control/troubleshooting.markdown (2)
95-105: LGTM! Clear network configuration guidance.The local network settings section provides clear steps for resolving URL communication issues.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
95-95: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
103-103: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
104-104: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
104-104: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
107-108: LGTM! Important configuration requirement.The media source section clearly states the YAML configuration requirement.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
107-107: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
source/_integrations/vicare.markdown (2)
118-118: LGTM! Improved entity_id description.The description for
entity_idis now clearer and more consistent with other actions.
121-142: LGTM! Well-documented new action.The new action
vicare.set_dhw_circulation_pump_scheduleis well-documented with clear parameters and a helpful example schedule.source/_integrations/bring.markdown (5)
30-30: Improved clarity in the integration description.The change from "interact with" to "sync" better reflects the actual functionality of the integration.
32-44: Well-structured introduction and feature overview.The new sections "About Bring!" and "How you can use this integration" provide valuable context and clear use cases for users.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
32-32: Trailing punctuation in heading
Punctuation: '!'(MD026, no-trailing-punctuation)
47-54: Clear authentication instructions.The prerequisites section now includes detailed instructions for users who signed up using third-party services, making it easier for users to set up the integration.
147-194: Excellent automation example with blueprint.The automation example is well-documented and includes both a blueprint import option and a detailed YAML configuration.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
151-151: Bare URL used
null(MD034, no-bare-urls)
211-215: Comprehensive troubleshooting section.The troubleshooting section provides clear guidance on common issues and how to report problems effectively.
🧰 Tools
🪛 LanguageTool
[formatting] ~211-~211: These punctuation marks differ from each other. Use only one if you are ending a sentence.
Context: ...net connection to communicate with Bring!. If you encounter issues, verify that yo...(DOUBLE_PUNCTUATION_PREMIUM)
[style] ~211-~211: Using many exclamation marks might seem excessive (in this case: 38 exclamation marks for a text that’s 8700 characters long)
Context: ...ction is stable. Additionally, the Bring! service itself may experience downtime,...(EN_EXCESSIVE_EXCLAMATION)
source/_posts/2025-02-05-release-20252.markdown (3)
479-483: Clear introduction to patch releases.The new section provides a clear explanation of the patch release schedule and purpose.
485-516: Well-documented patch release 2025.2.1.The changes are properly documented with:
- Clear references to pull requests
- Attribution to contributors
- Concise descriptions of changes
572-598: Well-documented patch release 2025.2.2.The changes are properly documented with:
- Clear references to pull requests
- Attribution to contributors
- Concise descriptions of changes
source/_integrations/telegram_bot.markdown (2)
293-293: Clear documentation of message_thread_id support.The notification platform description now includes message_thread_id support, maintaining consistency with other attributes.
614-624: Helpful example for topic messaging.The new example clearly demonstrates how to send messages to specific topics within a group.
source/changelogs/core-2025.2.markdown (4)
1-10: LGTM!The header section is well-structured with proper YAML frontmatter and introduction text.
12-1360: LGTM!The main release changes are well-documented with consistent formatting and proper attribution.
1361-1445: LGTM!The 2025.2.1 release changes are properly documented with consistent formatting.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
1395-1395: Link and image reference definitions should be needed
Unused link or image reference definition: "#137448"(MD053, link-image-reference-definitions)
1446-1476: LGTM!The 2025.2.2 release changes are properly documented with consistent formatting.
Proposed change
I have added a service to configure the schedule for my circulation pump. This allows disabling the pump when nobody is at home and re-enabling it when someone returns.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit
New Features
Bug Fixes
entity_idin the description of thevicare.set_vicare_modeaction for better accuracy.