Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain use of collection_key for energy cards #37335

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Feb 6, 2025

Proposed change

This option is currently undocumented.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Introduced a new "Using Multiple Collections" section in the energy cards documentation that explains how to enable multiple date selections. Detailed instructions guide users on configuring cards with a required collection key prefix to ensure proper setup and prevent errors.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 6b869aa
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67a4feb8453a5c00086183ab
😎 Deploy Preview https://deploy-preview-37335--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karwosts karwosts marked this pull request as ready for review February 6, 2025 18:15
Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

📝 Walkthrough

Walkthrough

The pull request adds a new documentation section titled “Using Multiple Collections” to the energy cards documentation. This section explains how to configure energy cards to support multiple date selections by introducing a new YAML variable, collection_key, which must begin with the prefix "energy_". An example is provided, and the documentation clarifies that any collection_key not following this naming convention will result in an error. This update does not change the existing functionality.

Changes

File Change Summary
source/_dashboards/energy.markdown Added a "Using Multiple Collections" section that details how to enable multiple date selections via a collection_key variable (must start with "energy_").

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_dashboards/energy.markdown (1)

238-242: Documentation Clarity for collection_key Section

The new "Using Multiple Collections" section clearly explains how users can link energy cards to distinct date selections using the collection_key variable. To further polish the prose, consider a minor grammatical tweak on line 242. Instead of:

  All energy cards support use of collection_key option.

it might read better as:

  All energy cards support the use of the collection_key option.

This small change improves clarity and conforms to standard English grammar.

[minor]

-All energy cards support use of `collection_key` option.
+All energy cards support the use of the `collection_key` option.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~242-~242: You might be missing the article “the” here.
Context: ...rror). All energy cards support use of collection_key option. ### Examples Ex...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66f1215 and 807cc58.

📒 Files selected for processing (1)
  • source/_dashboards/energy.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_dashboards/energy.markdown

[uncategorized] ~242-~242: You might be missing the article “the” here.
Context: ...rror). All energy cards support use of collection_key option. ### Examples Ex...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use of collection_key option. ### Examples Example view with multiple collections: ```yam...

(REPEATED_VERBS)

🪛 markdownlint-cli2 (0.17.2)
source/_dashboards/energy.markdown

244-244: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

🔇 Additional comments (1)
source/_dashboards/energy.markdown (1)

244-261: Markdown Formatting and Example Clarification

The examples provided from line 244 onward are very helpful for illustrating how a multi-collection view is configured. A couple of formatting improvements are recommended:

  1. Ensure that headings (e.g., "### Examples") are surrounded by a blank line to satisfy markdownlint guidelines (MD022).
  2. The introductory phrase "Example view with multiple collections:" is useful, but double-check that the text does not inadvertently repeat any verb or description from the title.

If needed, add a blank line above the "### Examples" heading for better readability.

[minor]
[markdown]

🧰 Tools
🪛 LanguageTool

[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use of collection_key option. ### Examples Example view with multiple collections: ```yam...

(REPEATED_VERBS)

🪛 markdownlint-cli2 (0.17.2)

244-244: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
source/_dashboards/energy.markdown (2)

237-240: Improve documentation clarity and grammar in the new section header and description.
The new "Using Multiple Collections" section is a valuable addition that clearly explains how to link energy cards to separate date selections. To further enhance clarity, consider rephrasing the sentence on line 240 from:
  All energy cards support use of collection_key option.
to:
  All energy cards support the collection_key option.

This small change resolves the repeated verb issue flagged by static analysis and improves readability. Also, ensure that headings are surrounded by blank lines (per markdownlint MD022) if not already enforced by your markdown formatter.

-All energy cards support use of `collection_key` option.
+All energy cards support the `collection_key` option.

241-255: Enhance YAML example clarity and inline commentary.
The provided YAML example clearly demonstrates how to configure multiple collections by linking cards via the collection_key. To further aid readers, consider adding or refining inline comments so that the association between each energy card and its corresponding date selection is unmistakable. For example, you might clarify that the first energy-date-selection (without a specified collection_key) serves as the default, while the second (with collection_key: energy_2) enables an alternative date selection.

A potential refinement could be:

 cards:
-  - type: energy-date-selection
-  - type: energy-date-selection
-    collection_key: energy_2
-  # This card is linked to the first (default) date selection
-  - type: energy-usage-graph
-  # This card is linked to the second date selection
-  - type: energy-usage-graph
-    collection_key: energy_2
+  - type: energy-date-selection  # Default date selection
+  - type: energy-date-selection  # Secondary date selection
+    collection_key: energy_2
+  - type: energy-usage-graph    # Linked to the default date selection
+  - type: energy-usage-graph    # Linked to the secondary date selection
+    collection_key: energy_2

Feel free to adjust the inline comments as needed to match the intended guidance.

🧰 Tools
🪛 LanguageTool

[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use of collection_key option. ### Examples Example view with multiple collections: ```yam...

(REPEATED_VERBS)

🪛 markdownlint-cli2 (0.17.2)

244-244: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 807cc58 and 6b869aa.

📒 Files selected for processing (1)
  • source/_dashboards/energy.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_dashboards/energy.markdown

[grammar] ~244-~244: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...rt use of collection_key option. ### Examples Example view with multiple collections: ```yam...

(REPEATED_VERBS)

🪛 markdownlint-cli2 (0.17.2)
source/_dashboards/energy.markdown

244-244: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @karwosts 👍

../Frenck

@frenck frenck merged commit 77063bc into current Feb 6, 2025
9 checks passed
@frenck frenck deleted the karwosts-patch-2 branch February 6, 2025 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants