Skip to content

Fix front page bug#33584

Merged
balloob merged 1 commit into
home-assistant:currentfrom
Madelena:fix-front-page-bug
Jul 6, 2024
Merged

Fix front page bug#33584
balloob merged 1 commit into
home-assistant:currentfrom
Madelena:fix-front-page-bug

Conversation

@Madelena
Copy link
Copy Markdown
Contributor

@Madelena Madelena commented Jul 6, 2024

Proposed change

The footer of the front page is at the wrong place due to a bad code commit. The original code has been restored.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Introduced a sponsor section on the main page, complete with a "Sponsored by" header and a Nabu Casa logo link within a material card.

@home-assistant home-assistant Bot added the current This PR goes into the current branch label Jul 6, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 6, 2024

Walkthrough

Walkthrough

The HTML layout was restructured to add a new sponsor section. This new section includes a header labeled "Sponsored by" and features a Nabu Casa logo within a material card that links to the sponsor's site.

Changes

Files Change Summary
source/index.html Added a new sponsor section with a header and a Nabu Casa logo within a material card

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 0938360 and 8197741.

Files selected for processing (1)
  • source/index.html (1 hunks)
Additional context used
Path-based instructions (1)
source/index.html (6)

Pattern */**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

Pattern */**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

Pattern */**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"


Pattern */**(html|markdown|md): - Use sentence-style capitalization also in headings.


Pattern */**(html|markdown|md): do not comment on HTML used for icons


Pattern */**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.

Additional comments not posted (2)
source/index.html (2)

329-343: Verify the new sponsor section.

Ensure that the link to Nabu Casa is correct and the image is accessible with the correct alt text.

Verification successful

Verify the new sponsor section.

The URLs for the Nabu Casa link and the image are correct and accessible.

The alt text for the image is "Nabu Casa logo," which is appropriate.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the new sponsor section.

# Test: Check if the URL and image source are accessible. Expect: 200 OK status.
curl -o /dev/null -s -w "%{http_code}\n" "https://www.nabucasa.com"
curl -o /dev/null -s -w "%{http_code}\n" "https://www.home-assistant.io/images/sponsors/nabu_casa.svg"

Length of output: 178


319-324: Verify the new press link and image.

Ensure that the link is correct and the image is accessible with the correct alt text.

Verification successful

URLs and Image Accessibility Verified

The new press link and image are correctly structured and accessible. Both URLs returned a 200 OK status, confirming their availability.

  • Line 319-324: The URL https://www.heise.de/select/ct/2017/26/1513910625909214 and the image source https://www.home-assistant.io/images/press/ct.png are accessible.
  • The alt text for the image is correctly set as "Ct logo".
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the new press link and image.

# Test: Check if the URL and image source are accessible. Expect: 200 OK status.
curl -o /dev/null -s -w "%{http_code}\n" "https://www.heise.de/select/ct/2017/26/1513910625909214"
curl -o /dev/null -s -w "%{http_code}\n" "https://www.home-assistant.io/images/press/ct.png"

Length of output: 199


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 6, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 8197741
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66889d58167bf6000856c6b9
😎 Deploy Preview https://deploy-preview-33584--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@balloob balloob merged commit 57ef6bb into home-assistant:current Jul 6, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2024
@Madelena Madelena deleted the fix-front-page-bug branch July 8, 2024 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants