Skip to content

Fix-green-landing-page#33541

Merged
frenck merged 13 commits into
home-assistant:currentfrom
Madelena:fix-green-landing-page
Jul 5, 2024
Merged

Fix-green-landing-page#33541
frenck merged 13 commits into
home-assistant:currentfrom
Madelena:fix-green-landing-page

Conversation

@Madelena
Copy link
Copy Markdown
Contributor

@Madelena Madelena commented Jul 3, 2024

Proposed change

Fixes formatting and header for the HA Green landing page, after the renovation of the overall website last week.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Introduced dark theme for page headers on specific pages.
  • Style Enhancements

    • Adjusted layout and styling for various elements to improve visual presentation and user experience.
    • Updated font families and sizes across multiple sections for a consistent look.
  • Content Updates

    • Removed press coverage section from the homepage.
    • Modified sponsor section link structure for better organization.

@home-assistant home-assistant Bot added the current This PR goes into the current branch label Jul 3, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 3, 2024

Walkthrough

Walkthrough

This update introduces several styling and layout adjustments across various HTML and CSS files to enhance the site's visual appeal and user experience. Key changes include implementing a dark header on specific pages, refining grid layouts, updating font styles and sizes, and modifying content display and sidebar configurations based on page types.

Changes

Files Change Summary
source/_layouts/default.html Refined layout structure for different page types, updated header class, grid elements, and content display.
source/green/index.html, source/index.html Introduced dark_header attribute, removed press coverage section, and adjusted sponsor section.
source/green/styles.css Updated styles for header, footer, navigation, and text elements, including new font families and sizes.

Sequence Diagrams

No sequence diagrams are needed for this change set as it primarily involves visual and layout adjustments without significant new features or control flow modifications.


Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 4f28921 and 77e424d.

Files selected for processing (2)
  • source/green/styles.css (16 hunks)
  • source/index.html (2 hunks)
Additional context used
Path-based instructions (1)
source/index.html (6)

Pattern */**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

Pattern */**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

Pattern */**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"


Pattern */**(html|markdown|md): - Use sentence-style capitalization also in headings.


Pattern */**(html|markdown|md): do not comment on HTML used for icons


Pattern */**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.

Additional comments not posted (17)
source/index.html (2)

5-5: LGTM!

The dark_header attribute is correctly set to true, aligning with the PR objectives.


319-323: LGTM!

The new press link is correctly added and follows the existing structure.

source/green/styles.css (15)

15-18: LGTM!

The added styles for .grid-wrapper within .site-header set a maximum width and padding, which should improve the layout consistency.


20-23: LGTM!

The added styles for .grid-wrapper within footer set a maximum width and padding, which should improve the layout consistency.


29-31: LGTM!

The added styles for .distributors set the font-family to 'Instrument Sans', Figtree, sans-serif, ensuring consistency with the overall design.


649-649: LGTM!

The modified top property for .content-wrapper.sticky-faq is set to 64px, which should align well with the overall layout.


689-691: LGTM!

The modified top property for .wrappernav.wrappernavlocal is set to 64px, and transitions for top and background-color are added, which should enhance the user experience.


693-697: LGTM!

The added styles for .wrappernav.scrolled include backdrop-filter, background-color, and top properties, which should improve the visual presentation when the user scrolls.


702-709: LGTM!

The modified max-width and added padding for .navgrid should enhance the layout consistency.


746-746: LGTM!

The modified font-family for .button.black is set to Figtree, sans-serif, ensuring consistency with the overall design.


794-796: LGTM!

The modified font-size, font-family, and font-weight for .nav-link.nav-local ensure consistency with the overall design.


1029-1029: LGTM!

The modified letter-spacing for .heading-regular ensures consistency with the overall design.


1040-1041: LGTM!

The modified letter-spacing for .heading-small ensures consistency with the overall design.


1370-1378: LGTM!

The modified font-family and letter-spacing for .paragraph-m ensure consistency with the overall design.


1518-1520: LGTM!

The modified font-family and letter-spacing for .main-paragraph-w ensure consistency with the overall design.


1874-1876: LGTM!

The modified font-family and letter-spacing for .paragraph-small ensure consistency with the overall design.


1957-1957: LGTM!

The modified font-family for .alt is set to Figtree, sans-serif, ensuring consistency with the overall design.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 3, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 77e424d
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6687a243d32c2e000825d1d9
😎 Deploy Preview https://deploy-preview-33541--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 4, 2024
@c0ffeeca7
Copy link
Copy Markdown
Contributor

Some unrelated changes (gemfile.lock) sneaked in

Comment thread Gemfile.lock Outdated
@frenck frenck merged commit 4fadb43 into home-assistant:current Jul 5, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants