Skip to content

MQTT Vacuum docs#3354

Merged
balloob merged 6 commits into
home-assistant:nextfrom
johnboiles:mqtt-vacuum
Sep 22, 2017
Merged

MQTT Vacuum docs#3354
balloob merged 6 commits into
home-assistant:nextfrom
johnboiles:mqtt-vacuum

Conversation

@johnboiles
Copy link
Copy Markdown
Contributor

@johnboiles johnboiles commented Sep 11, 2017

Basic MQTT vacuum support

Useful for retrofitting older Roombas and other non-wifi vacuums to be controlled via Home Assistant.

Pull request in home-assistant (if applicable): home-assistant/core#9386

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Sep 12, 2017
Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things I thing @frenck missed :)

Comment thread source/_components/vacuum.mqtt.markdown Outdated
Configuration variables:

- **name** (*Optional*): The name of the vacuum.
- **supported_features** (*Optional*): List of features that the vacuum supports (possible values are `turn_on`, `turn_off`, `pause`, `stop`, `return_home`, `battery`, `status`, `locate`, `clean_spot`). Defaults to .
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value is missing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Comment thread source/_components/vacuum.mqtt.markdown Outdated

### {% linkable_title Retrofitting a non-wifi Roomba with an ESP8266 %}

- [This repo](https://github.com/johnboiles/esp-roomba-mqtt) has MQTT client firmware for retrofitting your old Roomba
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dot is missing at the end of the sentence.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 12, 2017

@Landrash Pff sorry, I've should not have missed that. I really need to get more sleep these days 😨

@johnboiles
Copy link
Copy Markdown
Contributor Author

Hey @frenck @Landrash the corresponding PR oh home-assistant just got merged this morning. Could y'all take another look and merge if this looks good?

@balloob balloob merged commit 28b5ca9 into home-assistant:next Sep 22, 2017
@balloob balloob modified the milestone: 0.54 Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants