Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AngellusMortis as code-owner Unifi Protect #32835

Merged
merged 2 commits into from
May 18, 2024

Conversation

balloob
Copy link
Member

@balloob balloob commented May 18, 2024

Proposed change

Docs change for home-assistant/core#117708

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@balloob balloob requested a review from bdraco as a code owner May 18, 2024 20:53
@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 18, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented May 18, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit c16440e
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6649158691a3380007b007de
😎 Deploy Preview https://deploy-preview-32835--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@frenck frenck removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label May 18, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @balloob 👍

../Frenck

@frenck frenck merged commit bc4f57f into current May 18, 2024
4 checks passed
@frenck frenck deleted the adjust-code-owner-protect branch May 18, 2024 20:55
@home-assistant home-assistant bot removed the in-progress This PR/Issue is currently being worked on label May 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants