Skip to content

Add documentation for Todoist component#3283

Merged
MartinHjelmare merged 6 commits into
home-assistant:nextfrom
Jay2645:next
Sep 14, 2017
Merged

Add documentation for Todoist component#3283
MartinHjelmare merged 6 commits into
home-assistant:nextfrom
Jay2645:next

Conversation

@Jay2645
Copy link
Copy Markdown
Contributor

@Jay2645 Jay2645 commented Aug 31, 2017

Description:
This is the documentation for the Todoist component that I've been working on.

Pull request in home-assistant (if applicable): home-assistant/core#9236

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Aug 31, 2017
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Minor spelling & grammar issues found.
@Jay2645, Could you please take a look?

- **custom_projects** (*Optional*): Details on any "custom" binary sensor projects you want to create.
- **name** (*Required*): The name of your custom project. Only required if you specify that you want to create a custom project.
- **due_date_days** (*Optional*): Only include tasks due within this many days. If you don't have any tasks with a due date set, this returns nothing.
- **labels** (*Optional*): Any labels you want to filter for. All tasks in this sensor will include this label.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • for needs to go. -> Any labels you want to filter.
    Alternatively, you could replace the whole description with: Only include tasks which have this label

Unclear documentation:

  • If I set two labels, will the tasks actually need to have both? (is it AND or OR?)


- A project containing *all* the tasks on this account due within the next week.

- A projct containing everything with the label "Homework", taking only 2 projects into account.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • projct-> project


### {% linkable_title Services %}

Todoist also comes with access to a service, `todoist.new_task`. This service can be used to create a new Todoist task. You can specify labels and a project, or you can leave them blank and the task will go to your "Inbox" project.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • Missing comma after blank -> or you can leave them blank, and the task


- **labels** (*Optional*): Any labels you want to add to the task, separated by commas.

- **priority** (*Optional*): The priority of the task, from 1-4. Again, 1 means least important and 4 means most important.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • Missing coma after important -> means least important, and 4 means

---
layout: page
title: "Todoist"
description: "Instructions how to integrate Todoist into Home Assistant."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • Instructions how to integrate -> Instructions on how to integrate

@Jay2645
Copy link
Copy Markdown
Contributor Author

Jay2645 commented Aug 31, 2017

@frenck That's what I get for writing documentation at 3 AM. Your changes should be live now.

@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 2, 2017

@Jay2645 hehe, that sounds familiar 🤣
Thanks for fixing it! 🥇

@MartinHjelmare MartinHjelmare merged commit 2f72919 into home-assistant:next Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants