Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reolink PIR entity docs #32794

Merged
merged 1 commit into from
May 16, 2024
Merged

Add Reolink PIR entity docs #32794

merged 1 commit into from
May 16, 2024

Conversation

starkillerOG
Copy link
Contributor

Proposed change

Add Reolink PIR entity docs

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels May 15, 2024
Copy link

netlify bot commented May 15, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit ef68836
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6644d1e30dbd310008c3e0fe
😎 Deploy Preview https://deploy-preview-32794--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpbede jpbede added the parent-merged The parent PR has been merged already label May 15, 2024
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one minor question on the use of '*'.

source/_integrations/reolink.markdown Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 15, 2024 22:32
@starkillerOG starkillerOG marked this pull request as ready for review May 16, 2024 05:57
@home-assistant home-assistant bot requested a review from davet2001 May 16, 2024 05:57
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck dismissed davet2001’s stale review May 16, 2024 09:40

Comment addressed

@frenck frenck merged commit bf4aa40 into next May 16, 2024
8 checks passed
@frenck frenck deleted the starkillerOG-patch-3 branch May 16, 2024 09:40
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label May 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants