Add Bayesian Binary Sensor documentation#3268
Merged
Merged
Conversation
Why: * I have a PR that is in progress on the main Hass repo. This change addresses the need by: * `binary_sensor.bayesian.markdown` in the `_components` directory.
3 tasks
MartinHjelmare
requested changes
Aug 28, 2017
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Maybe write somewhat more explicitly that for each sub-observation it's required to choose between state and numeric state platforms?
| logo: home-assistant.png | ||
| ha_category: Binary Sensor | ||
| ha_iot_class: "Local Polling" | ||
| ha_release: 0.52 |
Landrash
added
the
new-integration
MartinHjelmare
approved these changes
Aug 29, 2017
frenck
requested changes
Aug 30, 2017
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
@jlmcgehee21 Could you please take a look?
| Otherwise, the sensor is `off`. | ||
|
|
||
| This allows for the detection of complex events that may not be readily | ||
| observable, i.e. cooking, showering, in bed, start of morning routine, etc. It |
Member
There was a problem hiding this comment.
Spelling & Grammar:
- Missing comma after
i.e.->i.e., cooking, showering start of morning routine->the start of a morning routine
| This allows for the detection of complex events that may not be readily | ||
| observable, i.e. cooking, showering, in bed, start of morning routine, etc. It | ||
| can also be used to gain greater confidence about events that _are_ directly | ||
| observable, but for which the sensors can be unreliable, i.e. presence. |
Member
There was a problem hiding this comment.
Spelling & Grammar:
- Missing comma after
i.e.->unreliable, i.e., presence
fabaff
approved these changes
Aug 30, 2017
Member
fabaff
left a comment
fabaff
left a comment
There was a problem hiding this comment.
I will merge it and address the issues later.
Thanks 🐦
Contributor
Author
|
👍 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
This change addresses the need by:
binary_sensor.bayesian.markdownin the_componentsdirectory.Description:
Pull request in home-assistant (if applicable): home-assistant/core#8810