Skip to content

add BH1750 light sensor platform doc#2821

Merged
fabaff merged 4 commits into
home-assistant:nextfrom
azogue:sensor-bh1750
Jun 22, 2017
Merged

add BH1750 light sensor platform doc#2821
fabaff merged 4 commits into
home-assistant:nextfrom
azogue:sensor-bh1750

Conversation

@azogue
Copy link
Copy Markdown
Member

@azogue azogue commented Jun 15, 2017

Description:

New BH1750 light sensor platform documentation

Pull request in home-assistant (if applicable): home-assistant/core#8050

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 16, 2017
Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes are needed but looks good in general.


The sensor can work with resolutions of 0.5 lx (high res mode 1), 1 lx (high res mode 2) or 4 lx (low res mode), and make measurements continuously or one time each call. To set any of these operation modes, select one of these combinations: `continuous_low_res_mode`, `continuous_high_res_mode_2`, `continuous_high_res_mode_1`, `one_time_high_res_mode_1`, `one_time_high_res_mode_2`, `one_time_low_res_mode`.

```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing yaml

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


It will output a table like this:

```bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't bash. Suggest you use text for highlighting.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Landrash, done!

Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent pr is merged. 🍪

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 2094220 into home-assistant:next Jun 22, 2017
@azogue azogue deleted the sensor-bh1750 branch July 8, 2017 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants