Skip to content

Rename 'Switch as x' to 'Change device type of a switch'#28128

Merged
frenck merged 1 commit into
currentfrom
rename-switch-as-x-to-change-device-type
Jul 8, 2023
Merged

Rename 'Switch as x' to 'Change device type of a switch'#28128
frenck merged 1 commit into
currentfrom
rename-switch-as-x-to-change-device-type

Conversation

@c0ffeeca7
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 commented Jul 7, 2023

Rename 'Switch as x' to 'Change device type of a switch'

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@c0ffeeca7 c0ffeeca7 requested a review from a team as a code owner July 7, 2023 15:52
@home-assistant home-assistant Bot added the current This PR goes into the current branch label Jul 7, 2023
Comment thread source/_integrations/switch_as_x.markdown
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Jul 7, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft July 7, 2023 17:03
@home-assistant home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jul 7, 2023
@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 7, 2023
@home-assistant

This comment was marked as resolved.

@frenck frenck removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 8, 2023
@frenck frenck marked this pull request as ready for review July 8, 2023 06:59
@home-assistant home-assistant Bot requested a review from frenck July 8, 2023 06:59
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @c0ffeeca7 👍

../Frenck

@home-assistant home-assistant Bot marked this pull request as draft July 8, 2023 07:00
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is going on with my keyboard navigation assigning different keys to the approval and request changes buttons 😢

Anyways, let me try this one again....

../Frenck

@frenck frenck marked this pull request as ready for review July 8, 2023 07:00
@home-assistant home-assistant Bot requested a review from frenck July 8, 2023 07:00
@frenck frenck merged commit ceb53db into current Jul 8, 2023
@frenck frenck deleted the rename-switch-as-x-to-change-device-type branch July 8, 2023 07:00
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Correction to reflect helper name change from "Switch as X" to "Change device type of a switch".

2 participants