Skip to content

Amcrest switch platform#2745

Closed
dparker18 wants to merge 3 commits into
home-assistant:nextfrom
dparker18:amcrest-switch-platform
Closed

Amcrest switch platform#2745
dparker18 wants to merge 3 commits into
home-assistant:nextfrom
dparker18:amcrest-switch-platform

Conversation

@dparker18
Copy link
Copy Markdown

Description:
added doc for new amcrest switch platform (home-assistant PR to follow)

@tchellomello
Copy link
Copy Markdown
Contributor

@dparker18 Nice work!! It looks good to me, however, you probably will need to update the PR to version 0.47 since the 0.46` (home-assistant/core#7866) was already created.

@tchellomello
Copy link
Copy Markdown
Contributor

LGTM 👍

@fabaff fabaff added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 3, 2017
Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent PR is merged.

@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 23, 2017

Closing PR.
Parent PR is closed because of being stale.

@frenck frenck closed this Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants