Skip to content

Add more info about the /api/history/period route#2699

Merged
fabaff merged 1 commit into
home-assistant:nextfrom
bokub:next
May 25, 2017
Merged

Add more info about the /api/history/period route#2699
fabaff merged 1 commit into
home-assistant:nextfrom
bokub:next

Conversation

@bokub
Copy link
Copy Markdown
Contributor

@bokub bokub commented May 23, 2017

Description:

The documentation about the /api/history/period route is too light:

  • we don't know if <timestamp> is the beginning or the end of the period
  • the end_time parameter is in the code but nowhere in the doc
  • we don't know the default period length

I added some precisions

@mention-bot
Copy link
Copy Markdown

@bokub, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @jackmakesthings to be potential reviewers.

@bokub
Copy link
Copy Markdown
Contributor Author

bokub commented May 23, 2017

P.S: Rendered preview:


capture

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff
Copy link
Copy Markdown
Member

fabaff commented May 25, 2017

@bokub, feel free to submit extensions/additions to the existing documentation against the current branch. This way it would be online immediately.

@fabaff fabaff merged commit e24bbff into home-assistant:next May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants