Skip to content

Remove fixed firmware issues#26790

Merged
frenck merged 1 commit into
home-assistant:currentfrom
starkillerOG:patch-110
Mar 31, 2023
Merged

Remove fixed firmware issues#26790
frenck merged 1 commit into
home-assistant:currentfrom
starkillerOG:patch-110

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Mar 29, 2023

Proposed change

NVR firmware v3.3.0 was released yesterday which fixes the mentioned issues.
Therefore remove them from the documentation.
The new firmware is available at https://reolink.com/download-center/

A version bump of the upstream library will ensure users on old firmware will get a repair issue that prompts them to update their NVRs to at least version v3.3.0.
In that way these issues will not occur anymore.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added current This PR goes into the current branch has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 29, 2023
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@home-assistant home-assistant Bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Mar 29, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck merged commit 284f637 into home-assistant:current Mar 31, 2023
@home-assistant home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Mar 31, 2023
@starkillerOG starkillerOG mentioned this pull request Mar 31, 2023
8 tasks
@starkillerOG
Copy link
Copy Markdown
Contributor Author

@frenck thanks for merging this.
Related to this docs PR, a firmware issue which is only documented in the next branch is also resolved, see #26808.
I am a bit unsure about the next/current branch, will this cause merge conflicts if I also remove these lines from the next branch?

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants