Skip to content

Deprecate automation trigger "state"#2665

Merged
Landrash merged 1 commit into
home-assistant:nextfrom
amelchio:trigger-on-attributes-not
May 22, 2017
Merged

Deprecate automation trigger "state"#2665
Landrash merged 1 commit into
home-assistant:nextfrom
amelchio:trigger-on-attributes-not

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

Description:

Even though the parent PR is a breaking change, the documentation does not change anything around. This is because the previous way of working was not documented.

The new meaning matches what one would expect from reading the example, so further elaboration is hopefully not needed.

Pull request in home-assistant (if applicable): home-assistant/core#7651

Also elaborate on the meaning of a state change when no filters are present.

Also make it clear that "from" and "to" are both optional.
@mention-bot
Copy link
Copy Markdown

@amelchio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @CCOSTAN and @fabaff to be potential reviewers.

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 22, 2017
Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and will be merged since parent PR has been merged.

@Landrash Landrash merged commit ab9950f into home-assistant:next May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants