Skip to content

Add Obihai Reboot button#26385

Merged
frenck merged 2 commits into
home-assistant:nextfrom
ejpenney:ejpenney_obihai_add_service
Mar 6, 2023
Merged

Add Obihai Reboot button#26385
frenck merged 2 commits into
home-assistant:nextfrom
ejpenney:ejpenney_obihai_add_service

Conversation

@ejpenney
Copy link
Copy Markdown
Contributor

@ejpenney ejpenney commented Feb 27, 2023

Proposed change

Adding a reboot button to Obihai

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Add Obihai reboot button core#88849
  • Link to parent pull request in the Brands repository: N/A
  • This PR fixes or closes issue: fixes: N/A

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@ejpenney ejpenney requested a review from dshokouhi as a code owner February 27, 2023 17:34
@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Feb 27, 2023
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Feb 27, 2023
Comment thread source/_integrations/obihai.markdown Outdated
@home-assistant home-assistant Bot marked this pull request as draft February 27, 2023 17:41
@home-assistant
Copy link
Copy Markdown

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ejpenney ejpenney force-pushed the ejpenney_obihai_add_service branch from 4aa58bf to 3762f35 Compare February 27, 2023 19:24
@ejpenney ejpenney changed the title Adding Obihai Reboot service Adding Obihai Reboot button Feb 27, 2023
@ejpenney ejpenney marked this pull request as ready for review February 27, 2023 19:32
@home-assistant home-assistant Bot requested a review from frenck February 27, 2023 19:32
@ejpenney ejpenney changed the title Adding Obihai Reboot button Add Obihai Reboot button Feb 28, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ejpenney 👍

../Frenck

@frenck frenck merged commit b098d8e into home-assistant:next Mar 6, 2023
@home-assistant home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Mar 6, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants