Skip to content

Add documentation for entity and device filters#26145

Merged
frenck merged 6 commits into
nextfrom
entity_filter_selector
Mar 9, 2023
Merged

Add documentation for entity and device filters#26145
frenck merged 6 commits into
nextfrom
entity_filter_selector

Conversation

@piitaya
Copy link
Copy Markdown
Member

@piitaya piitaya commented Feb 6, 2023

Proposed change

Add documentation for new filter option for entity and device selectors. Support for multiple device_classes has been added too.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Feb 6, 2023
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Feb 6, 2023

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant Bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Feb 6, 2023
@home-assistant home-assistant Bot added the has-parent This PR has a parent PR in another repo label Feb 6, 2023
When filter options are provided, the list of devices is filtered by devices
that at least provide one entity that matches the given conditions. Can be either
a object or a list of object.
type: map
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that [map, list] is not allowed so I set map.

@piitaya piitaya marked this pull request as ready for review February 6, 2023 17:23
@piitaya piitaya marked this pull request as draft February 6, 2023 21:00
@piitaya piitaya marked this pull request as ready for review February 7, 2023 09:35
@frenck frenck added the parent-merged The parent PR has been merged already label Feb 27, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread source/_docs/blueprint/selectors.markdown Outdated
Comment thread source/_docs/blueprint/selectors.markdown Outdated
@home-assistant home-assistant Bot marked this pull request as draft March 4, 2023 14:18
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Mar 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@piitaya piitaya marked this pull request as ready for review March 9, 2023 11:39
@home-assistant home-assistant Bot requested a review from frenck March 9, 2023 11:39
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @piitaya 👍

../Frenck

@frenck frenck merged commit 10253cf into next Mar 9, 2023
@frenck frenck deleted the entity_filter_selector branch March 9, 2023 11:43
@home-assistant home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Mar 9, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants