update frontend development guide#2591
Merged
Merged
Conversation
Landrash
requested changes
May 7, 2017
Contributor
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
Good addition but some feedback for formatting.
|
|
||
| `home-assistant/homeassistant/components/frontend/www_static/home-assistant-polymer`. | ||
|
|
||
| If you're planning on issuing a PR back to the HA codebase you need to fork the polymer project and add your fork as a remote. |
Contributor
There was a problem hiding this comment.
Replace HA with Home Assistant.
| ``` bash | ||
| $ cd homeassistant/components/frontend/www_static/home-assistant-polymer | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
I would suggest you combine the two parts into one for readability since the previous section is one part.
Landrash
approved these changes
May 8, 2017
Contributor
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
Looks good. Thank you 🍪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
update to frontend dev docs