Skip to content

update unique_id for slaves. Add to sensor min_value, max_value, zero…#25881

Merged
frenck merged 5 commits into
home-assistant:nextfrom
GrahamJB1:patch-2
Feb 3, 2023
Merged

update unique_id for slaves. Add to sensor min_value, max_value, zero…#25881
frenck merged 5 commits into
home-assistant:nextfrom
GrahamJB1:patch-2

Conversation

@GrahamJB1
Copy link
Copy Markdown
Contributor

Proposed change

Add min_value, max_value, zero_suppress to sensor. Add unique_id to b…

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

https://github.com/home-assistant/core/pull/86131/files

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@GrahamJB1 GrahamJB1 requested a review from janiversen as a code owner January 22, 2023 00:59
@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jan 22, 2023
Comment thread source/_integrations/modbus.markdown
Copy link
Copy Markdown
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the integer/float in required.

Copy link
Copy Markdown
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GrahamJB1 👍

../Frenck

@frenck frenck merged commit 9279cf2 into home-assistant:next Feb 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants