Add MJ and GJ#25862
Merged
Merged
Conversation
home-assistant
Bot
added
has-parent
This was referenced Jan 20, 2023
Contributor
|
Please fix the conflict and update source/_integrations/number.markdown too 👍 |
epenet
reviewed
Jan 25, 2023
epenet
reviewed
Jan 26, 2023
Contributor
epenet
left a comment
epenet
left a comment
There was a problem hiding this comment.
It's not enforced everywhere (yet) but could you please add a comma before or?
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
epenet
approved these changes
Jan 26, 2023
Contributor
epenet
left a comment
epenet
left a comment
There was a problem hiding this comment.
LGTM
This should included in 2023.2 (not quite sure how cherry-picking/milestones work here)
Contributor
Author
|
Awesome, thanks for the assistance. |
frenck
approved these changes
Jan 26, 2023
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Thanks, @SgtBatten 👍
../Frenck
home-assistant
Bot
removed
the
parent-merged
frenck
added
the
cherry-picked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add MJ and GJ as part of home-assistant/architecture#859
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.