Skip to content

Add documentation for DenonAVR telnet feature#25790

Merged
bdraco merged 4 commits into
home-assistant:nextfrom
dcmeglio:next
Feb 14, 2023
Merged

Add documentation for DenonAVR telnet feature#25790
bdraco merged 4 commits into
home-assistant:nextfrom
dcmeglio:next

Conversation

@dcmeglio
Copy link
Copy Markdown
Contributor

Proposed change

Adds a couple more supported AVRs to the list (based on my personal testing), fixed some mistakes related to zone 1/zone 2 really should be zone 2/zone 3, added documentation for new telnet feature.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jan 16, 2023
frenck
frenck previously approved these changes Jan 16, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR next This PR goes into the next branch labels Jan 16, 2023
@dcmeglio
Copy link
Copy Markdown
Contributor Author

@frenck per some PR reviews on the parent, I've changed the default value of use_telnet to true. To prevent a breaking change though it will remain false for existing installs but will be true if you setup a new install. I added text to hopefully make this clear but let me know if there is a better way.

@bdraco bdraco added the parent-merged The parent PR has been merged already label Feb 14, 2023
@bdraco bdraco merged commit 9898787 into home-assistant:next Feb 14, 2023
@home-assistant home-assistant Bot removed parent-merged The parent PR has been merged already awaits-parent Awaits the merge of an parent PR labels Feb 14, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants