Skip to content

Add code support for MQTT lock#25781

Merged
frenck merged 3 commits into
home-assistant:nextfrom
jbouwh:Add-code-support-for-MQTT-lock
Jan 23, 2023
Merged

Add code support for MQTT lock#25781
frenck merged 3 commits into
home-assistant:nextfrom
jbouwh:Add-code-support-for-MQTT-lock

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Jan 16, 2023

Proposed change

Add code support for MQTT lock

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added current This PR goes into the current branch has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 16, 2023
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@jbouwh jbouwh changed the base branch from current to next January 16, 2023 08:58
@home-assistant home-assistant Bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 16, 2023
@home-assistant home-assistant Bot added the next This PR goes into the next branch label Jan 16, 2023
@jbouwh jbouwh removed request for a team, bachya, dgomes and fabaff January 16, 2023 08:59
frenck
frenck previously approved these changes Jan 16, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jan 16, 2023
Comment thread source/_integrations/lock.mqtt.markdown Outdated
Comment thread source/_integrations/lock.mqtt.markdown Outdated
@jbouwh jbouwh force-pushed the Add-code-support-for-MQTT-lock branch from 3845061 to c06bacc Compare January 23, 2023 14:31
@jbouwh jbouwh added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Jan 23, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh 👍

../Frenck

@frenck frenck merged commit ed0309e into home-assistant:next Jan 23, 2023
@home-assistant home-assistant Bot removed the parent-merged The parent PR has been merged already label Jan 23, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants