Skip to content

Add optimistic config option for MQTT climate#25448

Merged
frenck merged 2 commits into
home-assistant:nextfrom
jbouwh:mqtt-climate-optimistic
Jan 2, 2023
Merged

Add optimistic config option for MQTT climate#25448
frenck merged 2 commits into
home-assistant:nextfrom
jbouwh:mqtt-climate-optimistic

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Dec 29, 2022

Proposed change

Add optimistic config option for MQTT climate.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Dec 29, 2022
@jbouwh jbouwh changed the title Add optimistic config optopn for MQTT climate Add optimistic config option for MQTT climate Dec 29, 2022
@home-assistant
Copy link
Copy Markdown

Hey there @emontnemery, mind taking a look at this feedback as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Dec 30, 2022
@frenck frenck merged commit b6dddd1 into home-assistant:next Jan 2, 2023
@home-assistant home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Jan 2, 2023
@jbouwh jbouwh added the parent-merged The parent PR has been merged already label Jan 2, 2023
@jbouwh jbouwh deleted the mqtt-climate-optimistic branch January 2, 2023 10:53
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner has-parent This PR has a parent PR in another repo integration: mqtt next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants