Updated SwitchBot documentation to include details about the lock#25421
Merged
Conversation
19 tasks
frenck
requested changes
Dec 28, 2022
Member
|
@dsypniewski home-assistant/core#84830 is merged so you should be able to simplify this now quick a bit. The lock I ordered was delayed a day so I'll do testing when it arrives in the morning. I think this addresses the concerns, but if anything goes wrong I'll address any quick fixes in a PR, or if its not something I can resolve or it is more involved I'll hide lock support behind a feature flag until it can be fixed. |
bdraco
reviewed
Dec 31, 2022
bdraco
reviewed
Jan 2, 2023
Co-authored-by: J. Nick Koston <nick@koston.org>
frenck
reviewed
Jan 2, 2023
frenck
reviewed
Jan 2, 2023
frenck
reviewed
Jan 2, 2023
frenck
approved these changes
Jan 2, 2023
Member
frenck
left a comment
There was a problem hiding this comment.
Thanks!
Happy New Year 🥂
../Frenck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Updated SwitchBot documentation to include details about the Lock
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.