Skip to content

Updated SwitchBot documentation to include details about the lock#25421

Merged
frenck merged 5 commits into
home-assistant:nextfrom
dsypniewski:switchbot-lock
Jan 2, 2023
Merged

Updated SwitchBot documentation to include details about the lock#25421
frenck merged 5 commits into
home-assistant:nextfrom
dsypniewski:switchbot-lock

Conversation

@dsypniewski
Copy link
Copy Markdown
Contributor

Proposed change

Updated SwitchBot documentation to include details about the Lock

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Dec 28, 2022
@bdraco bdraco added the parent-merged The parent PR has been merged already label Dec 28, 2022
Comment thread source/_integrations/switchbot.markdown Outdated
Comment thread source/_integrations/switchbot.markdown Outdated
Comment thread source/_integrations/switchbot.markdown Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 30, 2022

@dsypniewski home-assistant/core#84830 is merged so you should be able to simplify this now quick a bit.

The lock I ordered was delayed a day so I'll do testing when it arrives in the morning. I think this addresses the concerns, but if anything goes wrong I'll address any quick fixes in a PR, or if its not something I can resolve or it is more involved I'll hide lock support behind a feature flag until it can be fixed.

@frenck frenck added this to the 2023.1.0 milestone Dec 30, 2022
@dsypniewski dsypniewski requested review from frenck and removed request for Danielhiversen and bdraco December 31, 2022 04:57
Comment thread source/_integrations/switchbot.markdown Outdated
Comment thread source/_integrations/switchbot.markdown Outdated
Co-authored-by: J. Nick Koston <nick@koston.org>
Comment thread source/_integrations/switchbot.markdown Outdated
Comment thread source/_integrations/switchbot.markdown Outdated
Comment thread source/_integrations/switchbot.markdown
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Happy New Year 🥂

../Frenck

@frenck frenck merged commit a0e59c6 into home-assistant:next Jan 2, 2023
@home-assistant home-assistant Bot removed the parent-merged The parent PR has been merged already label Jan 2, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 3, 2023
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants