Skip to content

Add mA to Sensor/NumberDeviceClass.CURRENT units#25408

Merged
frenck merged 1 commit into
home-assistant:nextfrom
SukramJ:unit-mA
Dec 30, 2022
Merged

Add mA to Sensor/NumberDeviceClass.CURRENT units#25408
frenck merged 1 commit into
home-assistant:nextfrom
SukramJ:unit-mA

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Dec 26, 2022

Proposed change

Add mA to Sensor/NumberDeviceClass.CURRENT units

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@SukramJ SukramJ requested a review from a team as a code owner December 26, 2022 13:10
@home-assistant home-assistant Bot added current This PR goes into the current branch has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Dec 26, 2022
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Dec 26, 2022

I think the current branch is correct , because this unit is already available, but not documented.
The PR in the core only fixes the unit check for the next version.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current branch is correct

It isn't, as it depends on an upstream change.

Please change the target branch to next and git rebase your changes.

../Frenck

@SukramJ SukramJ changed the base branch from current to next December 29, 2022 09:07
@home-assistant home-assistant Bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Dec 29, 2022
@home-assistant home-assistant Bot added the next This PR goes into the next branch label Dec 29, 2022
@frenck frenck removed request for a team, Danielhiversen, bachya and bdraco December 29, 2022 09:47
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Dec 29, 2022
@frenck frenck added this to the 2023.1.0 milestone Dec 30, 2022
@frenck frenck merged commit cf0783e into home-assistant:next Dec 30, 2022
@home-assistant home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Dec 30, 2022
@SukramJ SukramJ deleted the unit-mA branch December 30, 2022 13:40
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 31, 2022
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants