Skip to content

Expand dsmr_reader documentation#24671

Merged
frenck merged 5 commits into
home-assistant:currentfrom
Glodenox:feature/expand-dsmr-reader-documentation
Jan 23, 2023
Merged

Expand dsmr_reader documentation#24671
frenck merged 5 commits into
home-assistant:currentfrom
Glodenox:feature/expand-dsmr-reader-documentation

Conversation

@Glodenox
Copy link
Copy Markdown
Contributor

Proposed change

Add more information on how the sensors in DSMR Reader are best used within the Energy Dashboard. Quite a few people were having issues with this (mostly due to the changes in the state class of some entities).

Additionally, I've better clarified the difference with the DSMR integration. I'm not sure why I previously stated that it provides an instance of DSMR Reader directly, as it has nothing to do with DSMR Reader at all.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

No other information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

For quite a few people, it wasn't clear which sensor entities are best used in the dashboard
@home-assistant home-assistant Bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 23, 2022
@Glodenox Glodenox changed the title Feature/expand dsmr reader documentation Expand dsmr_reader documentation Oct 23, 2022
Comment thread source/_integrations/dsmr_reader.markdown Outdated
Comment thread source/_integrations/dsmr_reader.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 24, 2022
First rename the default names of the entities in the integration, so we don't need to refer to the entity IDs
@home-assistant home-assistant Bot added the has-parent This PR has a parent PR in another repo label Dec 19, 2022
@frenck frenck added the parent-merged The parent PR has been merged already label Jan 23, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Glodenox 👍

../Frenck

@frenck frenck merged commit 0570eeb into home-assistant:current Jan 23, 2023
@home-assistant home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Jan 23, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in another repo

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants