Skip to content

Add config flow to Snapcast#24562

Merged
frenck merged 2 commits into
home-assistant:nextfrom
luar123:patch-2
Mar 30, 2023
Merged

Add config flow to Snapcast#24562
frenck merged 2 commits into
home-assistant:nextfrom
luar123:patch-2

Conversation

@luar123
Copy link
Copy Markdown
Contributor

@luar123 luar123 commented Oct 14, 2022

Proposed change

Remove YAML setup and add config flow.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Oct 14, 2022
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant Bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Oct 14, 2022
@home-assistant home-assistant Bot added the has-parent This PR has a parent PR in another repo label Oct 14, 2022
Comment thread source/_integrations/snapcast.markdown Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Oct 14, 2022
@epenet epenet changed the title Snapcast configflow Add config flow to Snapcast Mar 30, 2023
@epenet epenet added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Mar 30, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @luar123 👍

../Frenck

@frenck frenck merged commit 3b11aed into home-assistant:next Mar 30, 2023
@home-assistant home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Mar 30, 2023
@luar123 luar123 deleted the patch-2 branch March 30, 2023 07:18
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants