Add datadog component documentation#2452
Merged
MartinHjelmare merged 1 commit intoMay 7, 2017
Merged
Conversation
5 tasks
nunofgs
force-pushed
the
enhancement/add-datadog-component
branch
from
d39d169 to
51cc5ee
Compare
fabaff
added
the
new-integration
Landrash
requested changes
Apr 19, 2017
Contributor
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
Some minor feedback but looks good in general. 👍
| - **host** (*Optional*): IP address of your Datadog host, eg. 192.168.1.10. Defaults to `localhost`. | ||
| - **port** (*Optional*): Port to use. Defaults to 8125. | ||
| - **prefix** (*Optional*): Prefix to use. Defaults to `hass`. | ||
| - **rate** (*Optional*): The sample rate. Defaults to 1. |
Contributor
There was a problem hiding this comment.
What does the rate describe? Bytes, Liters, Minutes etc?
Contributor
Author
There was a problem hiding this comment.
It is the sample rate of UDP packets sent to Datadog. More information here.
Contributor
There was a problem hiding this comment.
Oh. That one would be tad hard to simplify. Keep it as is.
|
|
||
| Configuration variables: | ||
|
|
||
| - **host** (*Optional*): IP address of your Datadog host, eg. 192.168.1.10. Defaults to `localhost`. |
Contributor
There was a problem hiding this comment.
Suggest you change this to
The IP address or hostname of your Datadog host, e.g. 192.168.1.23. Defaults to
localhost.
nunofgs
force-pushed
the
enhancement/add-datadog-component
branch
from
51cc5ee to
dcd0e51
Compare
Landrash
approved these changes
Apr 20, 2017
Contributor
|
Looks good and can be merged after parent pr is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds documentation, screenshots and logo for the proposed
datadogcomponent.Pull request in home-assistant: home-assistant/core#7158