Missed breaking change to media_player in 2022.5#23380
Merged
Merged
Conversation
This adds a breaking changes section for the media_player, as additional states were added by dividing existing states.
frenck
requested changes
Jul 13, 2022
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds a breaking changes section for the media_player, as additional states were added by dividing existing states. Any previous triggers that relied on playing will not trigger on buffering, and the additional transitions between playing and buffering may cause additional triggering.
@emontnemery: I ended the section with your username as you made the changes, I hope that's appropriate.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
This is the architecture document that describes the breaking change: home-assistant/architecture#763
Checklist
currentbranch.