Skip to content

Missed breaking change to media_player in 2022.5#23380

Merged
frenck merged 3 commits into
home-assistant:currentfrom
tboby:patch-1
Jul 13, 2022
Merged

Missed breaking change to media_player in 2022.5#23380
frenck merged 3 commits into
home-assistant:currentfrom
tboby:patch-1

Conversation

@tboby
Copy link
Copy Markdown
Contributor

@tboby tboby commented Jul 13, 2022

Proposed change

This adds a breaking changes section for the media_player, as additional states were added by dividing existing states. Any previous triggers that relied on playing will not trigger on buffering, and the additional transitions between playing and buffering may cause additional triggering.

@emontnemery: I ended the section with your username as you made the changes, I hope that's appropriate.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • [x ] Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

This is the architecture document that describes the breaking change: home-assistant/architecture#763

Checklist

  • [ x] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
  • [ x] The documentation follows the Home Assistant documentation standards.

This adds a breaking changes section for the media_player, as additional states were added by dividing existing states.
@homeassistant
Copy link
Copy Markdown

Hi @tboby,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jul 13, 2022
Comment thread source/_posts/2022-05-04-release-20225.markdown Outdated
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tboby 👍

@frenck frenck merged commit e47f75f into home-assistant:current Jul 13, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants