Skip to content

Update Google Calendar Procedure to Generate Client ID and Client Secret#23342

Merged
frenck merged 1 commit into
home-assistant:currentfrom
rhino53150:patch-1
Jul 11, 2022
Merged

Update Google Calendar Procedure to Generate Client ID and Client Secret#23342
frenck merged 1 commit into
home-assistant:currentfrom
rhino53150:patch-1

Conversation

@rhino53150
Copy link
Copy Markdown
Contributor

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@rhino53150 rhino53150 requested a review from allenporter as a code owner July 10, 2022 12:40
@homeassistant
Copy link
Copy Markdown

Hi @rhino53150,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jul 10, 2022
@allenporter allenporter changed the title Updated Procedure to Generate Client ID and Client Secret Update Google Calendar Procedure to Generate Client ID and Client Secret Jul 10, 2022
Copy link
Copy Markdown
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think generally you're removing the test users since they aren't needed because you need to set the oauth project to Production -- though i think it was left there since many people skip the step of setting things to production. Removing seems OK.

@frenck frenck merged commit 91506e3 into home-assistant:current Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants