Skip to content

Update links to smartthings developer website#23255

Merged
frenck merged 3 commits into
home-assistant:currentfrom
mbo18:patch-5
Jul 7, 2022
Merged

Update links to smartthings developer website#23255
frenck merged 3 commits into
home-assistant:currentfrom
mbo18:patch-5

Conversation

@mbo18
Copy link
Copy Markdown
Contributor

@mbo18 mbo18 commented Jul 2, 2022

Proposed change

Smartthings developer website has changed, so I updated all links the smartthings documentation

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@mbo18 mbo18 requested a review from andrewsayre as a code owner July 2, 2022 12:16
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jul 2, 2022
@mbo18 mbo18 marked this pull request as draft July 2, 2022 12:18
@klaasnicolaas klaasnicolaas changed the title Update links to smartthings developper website Update links to smartthings developer website Jul 2, 2022
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 3, 2022

Hi there @mbo18 👋

Any specific reason for this PR to be marked as draft at this point?

../Frenck

@mbo18
Copy link
Copy Markdown
Contributor Author

mbo18 commented Jul 3, 2022

Not really because it is finished. It includes the change I made in this PR: #22903
So I’m waiting for next week as I used the current branch (I don’t know if it matters or not)

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 3, 2022

If this PR contains two different changes (on to the existing documentation and another for new features), it should be split into separate PRs.

Please, if a merged new feature lands in HA 2022.7, that part should target the next branch.

@mbo18 mbo18 marked this pull request as ready for review July 6, 2022 20:22
@mbo18
Copy link
Copy Markdown
Contributor Author

mbo18 commented Jul 6, 2022

I've updated my PR (no more conflict + added a link I missed). It is now ready for review.
This PR now only contains updated links and so it is using the correct branch (current)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mbo18 👍

@frenck frenck merged commit 880fa45 into home-assistant:current Jul 7, 2022
@mbo18 mbo18 deleted the patch-5 branch July 7, 2022 08:58
chatziko pushed a commit to chatziko/home-assistant.io that referenced this pull request Jul 7, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants