Skip to content

Update application credentials instructions for google calendar OAuth#22980

Merged
frenck merged 4 commits into
home-assistant:currentfrom
allenporter:google-creds
Jul 9, 2022
Merged

Update application credentials instructions for google calendar OAuth#22980
frenck merged 4 commits into
home-assistant:currentfrom
allenporter:google-creds

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Proposed change

Update incorrect google calender oauth instructions based on discussion #70241

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jun 4, 2022
@allenporter allenporter changed the title Update stale google calendar OAuth instructions Update application credentials instructions for google calendar OAuth Jun 9, 2022
@allenporter allenporter mentioned this pull request Jun 21, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allenporter There is a merge conflict, could you take a look? 👍

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jun 29, 2022
@dannytsang
Copy link
Copy Markdown
Contributor

@allenporter looks good. Very minor comments and it covers #23270 as well. Thank you for updating it.

@allenporter allenporter closed this Jul 9, 2022
@allenporter allenporter deleted the google-creds branch July 9, 2022 15:33
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Jul 9, 2022
@allenporter allenporter restored the google-creds branch July 9, 2022 15:33
@allenporter allenporter reopened this Jul 9, 2022
Comment thread source/_integrations/google.markdown Outdated
Comment thread source/_integrations/google.markdown Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @allenporter 👍

@frenck frenck merged commit 158508f into home-assistant:current Jul 9, 2022
@rhino53150
Copy link
Copy Markdown
Contributor

"Generate Client ID and Client Secret" instructions are not correct. I just stepped through the process twice and step 11 states "You will then be automatically taken to the Scopes page. You do not need to add any scopes here so click Save and Continue to move to the Test users page." There is an "Optional Info" page after the "Scopes" page and then "Summary"

2022-07-09 13_49_59-Window

@allenporter
Copy link
Copy Markdown
Contributor Author

Can you send an edit with what makes sense to you?

@rhino53150
Copy link
Copy Markdown
Contributor

Can you send an edit with what makes sense to you?

  1. You will then be automatically taken to the Scopes page. You do not need to add any scopes here so click Save and Continue to move to the Optional info page. You do not need to add anything to the Optional info page so click Save and Continue which will take you to the Summary page. Click Back to Dashboard.

@allenporter
Copy link
Copy Markdown
Contributor Author

Can you send an edit with what makes sense to you?

  1. You will then be automatically taken to the Scopes page. You do not need to add any scopes here so click Save and Continue to move to the Optional info page. You do not need to add anything to the Optional info page so click Save and Continue which will take you to the Summary page. Click Back to Dashboard.

I meant send an actual edit PR e.g. https://community.home-assistant.io/t/editing-the-documentation-and-creating-a-pull-request-on-github/9573

Thank you for your contributions!

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants