Skip to content

Add powerview supported shade information#22944

Merged
bdraco merged 22 commits into
home-assistant:nextfrom
kingy444:add-powerview-shade-information
Jun 5, 2022
Merged

Add powerview supported shade information#22944
bdraco merged 22 commits into
home-assistant:nextfrom
kingy444:add-powerview-shade-information

Conversation

@kingy444
Copy link
Copy Markdown
Contributor

@kingy444 kingy444 commented Jun 1, 2022

Proposed change

In support of home-assistant/core#62788 and home-assistant/core#70775 updating documentation to display information of supported shades

As home-assistant/core#70775 is in the 2022.6 release and will implement support that could confuse the extent of Tilt functionality i have included what is currently supported

When home-assistant/core#62788 is implemented we need to update to 'Full Support' for type 8 & 47 only - Type 9 will be supported at a later date.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@kingy444 kingy444 requested a review from bdraco as a code owner June 1, 2022 12:31
@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jun 1, 2022
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Jun 1, 2022
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jun 1, 2022
@kingy444
Copy link
Copy Markdown
Contributor Author

kingy444 commented Jun 1, 2022

Relogging #22935 (comment) as apparantly i have no clue how to use any features of git outside of commit

@frenck frenck added the parent-merged The parent PR has been merged already label Jun 2, 2022
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco bdraco removed the in-progress This PR/Issue is currently being worked on label Jun 3, 2022
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Co-authored-by: J. Nick Koston <nick@koston.org>
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this on the first pass, but we need to fix it as this is how it looks on mobile

Screen Shot 2022-06-03 at 09 51 38

https://developers.home-assistant.io/docs/documenting/standards/#tables

@kingy444
Copy link
Copy Markdown
Contributor Author

kingy444 commented Jun 4, 2022

@bdraco formatting should be better for mobile now
image

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jun 4, 2022

That's much better. The ^ isn't really a pattern we have in the docs AFIACT. Maybe split it into two tables and put the ones that aren't fully working yet in the second table?

@kingy444
Copy link
Copy Markdown
Contributor Author

kingy444 commented Jun 4, 2022

Maybe split it into two tables

done 👍

Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jun 4, 2022

Looks much better. Some final suggestions above and then LGTM 👍

kingy444 and others added 4 commits June 5, 2022 11:24
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
@kingy444
Copy link
Copy Markdown
Contributor Author

kingy444 commented Jun 5, 2022

Looks much better. Some final suggestions above and then LGTM 👍

all done

@bdraco bdraco removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jun 5, 2022
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
Comment thread source/_integrations/hunterdouglas_powerview.markdown Outdated
@bdraco bdraco merged commit fa3855c into home-assistant:next Jun 5, 2022
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Jun 5, 2022
@kingy444 kingy444 deleted the add-powerview-shade-information branch June 5, 2022 03:40
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants