Skip to content

Opencv#2208

Merged
balloob merged 14 commits into
home-assistant:nextfrom
Teagan42:opencv
May 5, 2017
Merged

Opencv#2208
balloob merged 14 commits into
home-assistant:nextfrom
Teagan42:opencv

Conversation

@Teagan42
Copy link
Copy Markdown
Contributor

@Teagan42 Teagan42 commented Mar 6, 2017

Description:
Documentation around OpenCV image processing

Pull request in home-assistant (if applicable): home-assistant/core#7261

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Mar 7, 2017
Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor feedback.

logo: OpenCV_Logo.png
ha_category: Image Processing
featured: false
ha_release: 0.38
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bump before merging.

### {% linkable_title Configuration Home Assistant %}

```yaml
opencv:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in

# Example configuration.yaml entry

in the top of this example config.

Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback but looks good.

title: "OpenCV"
description: "Instructions how to setup OpenCV within Home Assistant."
date: 2017-03-05 22:36
date: 2017-04-01 22:36
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't update the date since this is the creation date.

To setup OpenCV with Home Assistant, add the following section to your `configuration.yaml` file:

```yaml
opencv:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in

# Example configuration.yaml entry

in the top of this example config.

Comment thread source/_components/opencv.markdown Outdated
There is a special camera, specifically for this:

```yaml
camera:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in

# Example configuration.yaml entry

in the top of this example config.

@Teagan42
Copy link
Copy Markdown
Contributor Author

Component is not ready enough apparently.

@Teagan42 Teagan42 closed this Mar 16, 2017
@Teagan42 Teagan42 reopened this Apr 24, 2017
@Teagan42 Teagan42 mentioned this pull request Apr 24, 2017
8 tasks
@Teagan42
Copy link
Copy Markdown
Contributor Author

Will bump version closer to when the main PR is approved.

classifier:
- file_path: /path/to/classifier/face.xml
name: face
- file_path: /path/to/classifier/face_profile.xml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two file_path? Can you clarify how/why they should be used?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say you want to match "Family" and you have a classifier for "Alok" (alok_face.xml), "Wife" (alok_wife_face.xml), "Kiddo" (alok_kiddo_face.xml).

This allows you to have:

classifier_group:
  name: 'Family'
  classifier:
    - name: 'Alok'
      file_path: 'alok_face.xml'
    - name: 'Wife'
      file_path: 'alok_wife_face.xml'
    - name: 'Kiddo'
      file_path: 'alok_kiddo_face.xml'

The matches would be:

Family: {
  Alok: {
    (region)
  },
  Wife: {
    (region)
  },
  Kiddo: {
    (region)
  }
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update docs tonight

@balloob balloob added this to the 0.44 milestone May 5, 2017
@balloob balloob merged commit bee8ba3 into home-assistant:next May 5, 2017
@balloob
Copy link
Copy Markdown
Member

balloob commented May 5, 2017

Cherry-picked for 0.44

balloob pushed a commit that referenced this pull request May 5, 2017
* Image processing opencv doc

* OpenCV doc

* OpenCV logo

* Doc updates

* Change docs to match opencv component

* Update docs

* Add comment to example

* Add camera config

* Add comment to example yaml

* Update docs to reflect the camera not being there

* Better documentation on configuration and attributes

* Reference hub

* Set release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants