Skip to content

Update webhook trigger documentation#21506

Merged
frenck merged 1 commit intohome-assistant:currentfrom
alderete:doc_webhook_edits
Feb 6, 2022
Merged

Update webhook trigger documentation#21506
frenck merged 1 commit intohome-assistant:currentfrom
alderete:doc_webhook_edits

Conversation

@alderete
Copy link
Copy Markdown
Contributor

@alderete alderete commented Feb 6, 2022

Proposed change

  • Correct explanation of data option in example curl command.
  • Separate data and security details into subsections
  • Expand on security details
  • HTTP request type support information

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Hopefully this is an improvement to the existing doc for existing behavior. It's also intended to make it easier to add or change details for future webhook improvements. (There are a couple open PRs for feature improvements, but those are not coupled to these changes.)

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
  • The documentation follows the Home Assistant documentation standards.

- Correct explanation of data option in example curl command.
- Separate data and security details into subsections
- Expand on security details
- Request type compatibility information
@homeassistant
Copy link
Copy Markdown

Hi @alderete,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alderete 👍

@frenck frenck merged commit 534b824 into home-assistant:current Feb 6, 2022
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in another repo label Feb 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants