Skip to content

Allow area, device, and entity selectors to optionally support multiple selections like target selector#20961

Merged
frenck merged 1 commit into
home-assistant:nextfrom
r-t-s:entity_selector
Mar 24, 2022
Merged

Allow area, device, and entity selectors to optionally support multiple selections like target selector#20961
frenck merged 1 commit into
home-assistant:nextfrom
r-t-s:entity_selector

Conversation

@r-t-s
Copy link
Copy Markdown
Contributor

@r-t-s r-t-s commented Dec 31, 2021

Proposed change

Changes to the Area, Device, and Entity selectors to allow them to select multiple entities.
The user interface is similar to the Area, Device and Entity selector component of the target selector.
Single or multi select is configured with the optional multiple option on the selector configuration.
The selectors can now potentially return a list of area, device, or entity IDs.

This is motivated by the need to have multiple entity selector so a blueprint can trigger on multiple entities.
But brings a consistent UI for the Area, Device, Entity, and Target selector.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: #62138 #11059
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Comment thread source/_docs/blueprint/selectors.markdown Outdated
frenck
frenck previously approved these changes Jan 4, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 4, 2022
Comment thread source/_docs/blueprint/selectors.markdown Outdated
Comment thread source/_docs/blueprint/selectors.markdown Outdated
Comment thread source/_docs/blueprint/selectors.markdown Outdated
@r-t-s r-t-s force-pushed the entity_selector branch from d6452fb to daf7c48 Compare March 14, 2022 02:27
@r-t-s
Copy link
Copy Markdown
Contributor Author

r-t-s commented Mar 14, 2022

Sorry I had to amend the previous commit. I received the following error when I tried to add a new commit:
! [remote rejected] entity_selector -> entity_selector (refusing to allow a Personal Access Token to create or update workflow .github/workflows/test.yml without workflow scope)

@frenck frenck added the parent-merged The parent PR has been merged already label Mar 14, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @r-t-s 👍

@frenck frenck merged commit 8ece472 into home-assistant:next Mar 24, 2022
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Mar 24, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2022
@r-t-s r-t-s deleted the entity_selector branch April 11, 2023 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants