Skip to content

Emphasize use of state variable for custom devices#20559

Merged
frenck merged 2 commits into
home-assistant:currentfrom
tktf50:isy994-docs1
Jan 5, 2022
Merged

Emphasize use of state variable for custom devices#20559
frenck merged 2 commits into
home-assistant:currentfrom
tktf50:isy994-docs1

Conversation

@tktf50
Copy link
Copy Markdown
Contributor

@tktf50 tktf50 commented Dec 3, 2021

Proposed change

This documentation update is primarily to emphasize the need to use a state variable (not an integer variable) when configuring a custom component. Also fixed a few grammatical errors.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

This documentation update is primarily to emphasize the need to use a state variable (not an integer variable) when configuration a custom component. Also fixed a few grammatical errors.
@tktf50 tktf50 requested a review from bdraco as a code owner December 3, 2021 18:17
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Dec 3, 2021
@homeassistant
Copy link
Copy Markdown

Hi @tktf50,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Comment thread source/_integrations/isy994.markdown Outdated
bdraco
bdraco previously requested changes Dec 6, 2021
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment above. Thanks 👍

#20559 (comment)

This documentation update is primarily to emphasize the need to use a state variable (not an integer variable) when configuring a custom component. Also fixed a few grammatical errors.
@tktf50 tktf50 requested a review from bdraco December 8, 2021 19:32
@bdraco bdraco dismissed their stale review December 16, 2021 01:15

Needs another review pass

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tktf50 👍

@frenck frenck merged commit 5796657 into home-assistant:current Jan 5, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 7, 2022
@tktf50 tktf50 deleted the isy994-docs1 branch November 14, 2022 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variable used for ISY994 custom device must be a state variable

4 participants