Skip to content

Fix markdownlint / spelling issues #3#19961

Merged
frenck merged 8 commits into
home-assistant:currentfrom
stefanroelofs:Fix-markdownlint-issues-#3
Oct 27, 2021
Merged

Fix markdownlint / spelling issues #3#19961
frenck merged 8 commits into
home-assistant:currentfrom
stefanroelofs:Fix-markdownlint-issues-#3

Conversation

@stefanroelofs
Copy link
Copy Markdown
Contributor

@stefanroelofs stefanroelofs commented Oct 25, 2021

Proposed change

Fix several issues related to markdownlint and spelling.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 25, 2021
frenck
frenck requested changes Oct 25, 2021
View reviewed changes
Comment thread source/_integrations/buienradar.markdown Outdated
Comment thread source/_integrations/buienradar.markdown Outdated
Comment thread source/_integrations/buienradar.markdown Outdated
Comment thread source/_integrations/cisco_webex_teams.markdown Outdated
Comment thread source/_integrations/cisco_webex_teams.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 25, 2021
@stefanroelofs stefanroelofs requested review from frenck and removed request for a team October 25, 2021 15:20
stefanroelofs and others added 3 commits October 26, 2021 11:19
@stefanroelofs
Created a table for the different sensors.
17c97ca 
This increases readability.
Also:
- Changed C into °C
- Updated other units
- Feel temperature is not correct English. Changed to wind chill factor.
- Do not refer to entityIds, use the human-readable name instead.
- Add a proper 'Note' in the bottom of the page.
@stefanroelofs
Renamed calendar.google.markdown file to (hopefully) resolve a merge …
6abc412 
…conflict.
@stefanroelofs
Merge branch 'current' into Fix-markdownlint-issues-#3
47b140e
@stefanroelofs
Copy link
Copy Markdown
Contributor Author

stefanroelofs commented Oct 27, 2021

The buienradar.markdown file probably needs another review
(see commit: 17c97ca)
But otherwise this is ready to be merged.
Thanks!

frenck
frenck reviewed Oct 27, 2021
View reviewed changes
Comment thread source/_integrations/buienradar.markdown Outdated
frenck
frenck approved these changes Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stefanroelofs 👍

@frenck frenck merged commit 7717ed9 into home-assistant:current Oct 27, 2021
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Oct 27, 2021
@stefanroelofs stefanroelofs deleted the Fix-markdownlint-issues-#3 branch October 27, 2021 10:13
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frenck frenck frenck approved these changes

@ctalkington ctalkington Awaiting requested review from ctalkington ctalkington is a code owner

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

@ludeeus ludeeus Awaiting requested review from ludeeus ludeeus is a code owner

Assignees

@stefanroelofs stefanroelofs

Labels

cla-signed current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanroelofs @frenck @homeassistant