Skip to content

Add documentation for ws66i core integration#19294

Merged
frenck merged 3 commits into
home-assistant:nextfrom
ssaenger:next
May 23, 2022
Merged

Add documentation for ws66i core integration#19294
frenck merged 3 commits into
home-assistant:nextfrom
ssaenger:next

Conversation

@ssaenger
Copy link
Copy Markdown
Contributor

@ssaenger ssaenger commented Sep 11, 2021

Proposed change

This is the documentation for the ws66i core integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Sep 11, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Sep 11, 2021
@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Sep 21, 2021
@ssaenger
Copy link
Copy Markdown
Contributor Author

ssaenger commented Dec 5, 2021

Comment to keep PR from going stale.

@ssaenger
Copy link
Copy Markdown
Contributor Author

ssaenger commented Mar 6, 2022

@frenck Is it appropriate to contact the vendor of the amplifier and ask for a discount code to be displayed on the documentation page?

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 7, 2022

@ssaenger I would say: No.

@bdraco bdraco added the parent-merged The parent PR has been merged already label May 8, 2022
Comment thread source/_integrations/ws66i.markdown Outdated
Comment thread source/_integrations/ws66i.markdown Outdated
Comment thread source/_integrations/ws66i.markdown Outdated
Comment on lines +36 to +38
### Service `ws66i.snapshot`

Take a snapshot of one or more zones' states. This service, and the following one are useful if you want to play a doorbell or notification sound and resume playback afterward.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have scenes that provide this functionality in Home Assistant, why does this integration provide its own logic for this?

Comment thread source/_integrations/ws66i.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label May 9, 2022
@ssaenger
Copy link
Copy Markdown
Contributor Author

@frenck Done. Custom services were removed in home-assistant/core#71717

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ssaenger 👍

@frenck frenck merged commit 8fb97fb into home-assistant:next May 23, 2022
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels May 23, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants