Skip to content

Update Comfoconnect documentation#19191

Closed
michaelarnauts wants to merge 1 commit intohome-assistant:nextfrom
michaelarnauts:comfoconnect_energy
Closed

Update Comfoconnect documentation#19191
michaelarnauts wants to merge 1 commit intohome-assistant:nextfrom
michaelarnauts:comfoconnect_energy

Conversation

@michaelarnauts
Copy link
Copy Markdown
Contributor

Proposed change

Modify documentation for renamed configuration keys.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Sep 3, 2021
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Sep 3, 2021
@probot-home-assistant

This comment has been minimized.

@michaelarnauts michaelarnauts changed the base branch from current to next September 3, 2021 13:27
@ludeeus ludeeus removed in-progress This PR/Issue is currently being worked on current This PR goes into the current branch labels Sep 3, 2021
@ludeeus ludeeus added next This PR goes into the next branch and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Sep 3, 2021
Copy link
Copy Markdown
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Can be merged when parent PR has been merged

@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Sep 3, 2021
@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Sep 22, 2021
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Sep 24, 2021
- power_total
- power_usage
- preheater_power_total
- preheater_energy_total
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't change this config item, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I'll close this PR and add the note in a new pr on the current branch.

@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Sep 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants