Rework modbus documentation.#17874
Merged
frenck merged 18 commits intohome-assistant:nextfrom May 25, 2021
janiversen:rework
Merged
Rework modbus documentation.#17874frenck merged 18 commits intohome-assistant:nextfrom janiversen:rework
frenck merged 18 commits intohome-assistant:nextfrom
janiversen:rework
Conversation
Member
Author
|
It tells me line 8 is wrong, but I did not touch the first lines at all, I am confused. |
Member
Author
|
@frenck Can I politely ask for advice...the build tell I have an error in line#8 column 284. But the commit does not touch line 8 (first line touched is 21, and that looks ok to me). Can you give a hint where/how to search for the problem ? thanks in advance. |
klaasnicolaas
requested changes
May 19, 2021
klaasnicolaas
previously requested changes
May 19, 2021
Member
Author
|
How super to see the site in a PR. This PR is ready from my side. |
This was referenced May 21, 2021
Member
Author
|
Do I miss to do something (it is no good idea, that I approve my own work) ? Code is coming in 2021.6 so I hope this doc. will as well. |
Co-authored-by: Klaas Schoute <klaas_schoute@hotmail.com>
Co-authored-by: Klaas Schoute <klaas_schoute@hotmail.com>
8 tasks
frenck
requested changes
May 25, 2021
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
reviewed
May 25, 2021
frenck
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The modbus documentation had become a bit "clouded" and information was not logically grouped. This PR tries to make a more logical view of how the configuration works, as well as making it easier to use the index.
It is based on next instead of current, due to the pending changes (2021.6) which are on next.
This also contains the documentation for the new Fan and Light platforms.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
I am not a native English speaker so suggestions to correct the wording will be accepted immediately.
Incorporates #15329, which are closed.
Incorporates #17207, which are closed.
Link to parent pull request in the codebase:
Add Modbus light integration core#42120
Add Modbus fan integration core#48558
Link to parent pull request in the Brands repository:
This PR fixes or closes issue:
Checklist
currentbranch.nextbranch.