Skip to content

Ezviz Documentation#17357

Closed
RenierM26 wants to merge 29 commits into
home-assistant:nextfrom
RenierM26:patch-1
Closed

Ezviz Documentation#17357
RenierM26 wants to merge 29 commits into
home-assistant:nextfrom
RenierM26:patch-1

Conversation

@RenierM26
Copy link
Copy Markdown
Contributor

@RenierM26 RenierM26 commented Apr 9, 2021

New pull request adds config_flow.
The documentation references services that doesn't exist in the integration. - Removed sections that refer to the services.

Proposed change

There is an open pull request that adds config flow to this integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Update Ezviz Component core#45722
  • Link to parent pull request in the Brands repository: N/A. The logos are already there.
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 9, 2021
@MartinHjelmare MartinHjelmare added the parent-merged The parent PR has been merged already label Apr 9, 2021
@MartinHjelmare
Copy link
Copy Markdown
Member

Please rebase your branch on latest next branch.

@RenierM26 RenierM26 changed the title Patch 1 Ezviz Documentation Apr 9, 2021
dependabot Bot and others added 23 commits April 9, 2021 16:08
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.2 to 1.11.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.11.2...v1.11.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Blog post for the April 2021 Android release

* Tweak date for preview

* Update source/_posts/2021-04-09-android-april-2021-release.markdown

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* Review comments

* Review comment

* Set date for the post

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
New pull request adds config_flow. 
The documentation references services that doesn't exist in the integration.  - Removed sections that refer to the services.
This reverts commit 80faff1, reversing
changes made to 876fa43.
This reverts commit 0d26902.
New pull request adds config_flow. 
The documentation references services that doesn't exist in the integration.  - Removed sections that refer to the services.
@MartinHjelmare
Copy link
Copy Markdown
Member

It may be easier to start over in a fresh branch based off next branch. The rebase didn't work cleanly. Unrelated commits are still present.

@RenierM26
Copy link
Copy Markdown
Contributor Author

Can I just delete this branch? I think it might close this Documentation PR.

If I then create a new one then we'll need to update the documentation url reference in the code pull request?

@RenierM26
Copy link
Copy Markdown
Contributor Author

Looks like I can still edit it? Just don't want to cause any more problems.

@RenierM26
Copy link
Copy Markdown
Contributor Author

New documentation pull request : #17364

@MartinHjelmare,
Really sorry for the inconvenience and any extra work caused by this mistake.

@MartinHjelmare
Copy link
Copy Markdown
Member

Good, thanks! No worries.

@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Apr 9, 2021
@RenierM26 RenierM26 deleted the patch-1 branch April 10, 2021 05:36
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants